Repository navigation
fix(comment-directive): re-enable rules on <!-- eslint-enable --> the same way ESLint does - #3231
Open
NgoQuocViet2001 wants to merge 2 commits into
Open
NgoQuocViet2001 wants to merge 2 commits into
NgoQuocViet2001 wants to merge 2 commits into
Conversation
…he same way ESLint does
🦋 Changeset detectedLatest commit: 567c8fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
<template>, a bare<!-- eslint-enable -->did not undo an earlier<!-- eslint-disable vue/x -->, and<!-- eslint-enable vue/x -->did not undo an earlier bare<!-- eslint-disable -->. The rule stayed off until</template>, while ESLint's own directives (and the same comments in<script>) turn it back on.Before: no messages. After:
vue/no-v-htmlon line 5, matching ESLint. A bareeslint-enablenow also clears per-rule block disables. Rules re-enabled witheslint-enable rulewhile a bareeslint-disableis active are no longer suppressed by it, and a later<!-- eslint-disable -->turns them off again. Line directives are unchanged.vitest run tests/lib/rules/comment-directive.test.ts: 3 of the 4 new cases fail on master, all 33 pass with the change.vitest run tests/lib(11771 passed),vitest run tests/integrations(2 passed),npm run tsc, eslint and prettier on the changed files.