Repository navigation
fix(no-deprecated-slot-attribute): apply ignore and ignoreParents to v-bind:slot - #3211
Merged
ota-meshi merged 1 commit intoOct 29, 2026
Conversation
… to `v-bind:slot`
🦋 Changeset detectedLatest commit: 977993e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
FloEdelmann
approved these changes
Oct 26, 2026
FloEdelmann
left a comment
Member
There was a problem hiding this comment.
Makes sense to me, thank you!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ignoreandignoreParentsoptions were only checked for a staticslot="...". A bound slot on the same ignored element, or under the same ignored parent, was still reported.--fixthen wrapped it in<template v-slot:[...]>, and that breaks named slots on web components:This change moves the existing ignore check into a small helper that both the
slotand thev-bind:slothandlers call. Elements that are not ignored are still reported and fixed as before. Follow-up to #2784, which addedignoreParents.npx vitest run tests/lib: 291 files, 11745 tests pass. On master, the 4 new cases fail.npm run build && npm run tsc: no errors.eslinton the changed files andmarkdownlint "**/*.md"report nothing.