Skip to content

fix(runtime-core): ensure props and attrs are shallow readonly in dev#8222

Closed
edison1105 wants to merge 6 commits into
vuejs:mainfrom
edison1105:fix/8216
Closed

fix(runtime-core): ensure props and attrs are shallow readonly in dev#8222
edison1105 wants to merge 6 commits into
vuejs:mainfrom
edison1105:fix/8216

Conversation

@edison1105

Copy link
Copy Markdown
Member

fix #8216

@ferferga

ferferga commented May 8, 2023

Copy link
Copy Markdown
Contributor

@edison1105 Why just in dev?

@edison1105

Copy link
Copy Markdown
Member Author

@edison1105 Why just in dev?

see #8216 (comment)

What is actually happening?
It normally modifies the count in the child component and is the latest value when the count is printed without any effect.
I found that switching to the dev version of the Vue SFC Playground does have this problem, and whenever you switch to prod there is a warning

@github-actions

github-actions Bot commented Oct 20, 2023

Copy link
Copy Markdown

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.7 kB 34.5 kB 31.1 kB
vue.global.prod.js 148 kB 53.8 kB 48 kB

Usages

Name Size Gzip Brotli
createApp 50.8 kB 19.9 kB 18.1 kB
createSSRApp 54.1 kB 21.2 kB 19.3 kB
defineCustomElement 53.1 kB 20.6 kB 18.8 kB
overall 64.5 kB 24.9 kB 22.6 kB

Comment thread packages/runtime-core/__tests__/componentProps.spec.ts Outdated
@edison1105 edison1105 changed the title fix(runtime-core): ensure props are shallow readonly in dev fix(runtime-core): ensure props and attrs are shallow readonly in dev Apr 21, 2024
@edison1105

Copy link
Copy Markdown
Member Author

close due to #8216 has been fix via a7cf742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Rejected

Development

Successfully merging this pull request may close these issues.

Why can I just change count and update it in the child component?

3 participants