Skip to content

fix(runtime-vapor): track and restore slot owner context for DynamicFragment rendering #14193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
edison1105 merged 3 commits into from
Dec 12, 2025
Merged

fix(runtime-vapor): track and restore slot owner context for DynamicFragment rendering #14193

edison1105 merged 3 commits into from
Dec 12, 2025
+81 −6

Conversation

@edison1105
Copy link
Member

@edison1105 edison1105 commented Dec 12, 2025 •
edited
Loading

close #14192

Copilot AI review requested due to automatic review settings December 12, 2025 01:28
@coderabbitai
Copy link

coderabbitai bot commented Dec 12, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edison/fix/transition

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Dec 12, 2025 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 85.2 kB 29.9 kB 26.4 kB
runtime-dom.global.prod.js 108 kB 40.6 kB 36.6 kB
vue.global.prod.js 166 kB 60.5 kB 53.9 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 48.2 kB 18.9 kB 17.3 kB
createApp 57.2 kB 22 kB 20.1 kB
createApp + vaporInteropPlugin 96.1 kB (+79 B) 35.5 kB (+33 B) 32 kB (+44 B)
createVaporApp 42.1 kB (+79 B) 15.5 kB (+31 B) 14.2 kB (+36 B)
createSSRApp 61.6 kB 23.8 kB 21.7 kB
defineCustomElement 63.3 kB 23.9 kB 21.8 kB
overall 71.9 kB 27.2 kB 24.9 kB

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 12, 2025 •
edited
Loading

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14193

npm i https://pkg.pr.new/@vue/compiler-core@14193

yarn add https://pkg.pr.new/@vue/[email protected]

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14193

npm i https://pkg.pr.new/@vue/compiler-dom@14193

yarn add https://pkg.pr.new/@vue/[email protected]

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14193

npm i https://pkg.pr.new/@vue/compiler-sfc@14193

yarn add https://pkg.pr.new/@vue/[email protected]

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14193

npm i https://pkg.pr.new/@vue/compiler-ssr@14193

yarn add https://pkg.pr.new/@vue/[email protected]

@vue/compiler-vapor

pnpm add https://pkg.pr.new/@vue/compiler-vapor@14193

npm i https://pkg.pr.new/@vue/compiler-vapor@14193

yarn add https://pkg.pr.new/@vue/[email protected]

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14193

npm i https://pkg.pr.new/@vue/reactivity@14193

yarn add https://pkg.pr.new/@vue/[email protected]

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14193

npm i https://pkg.pr.new/@vue/runtime-core@14193

yarn add https://pkg.pr.new/@vue/[email protected]

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14193

npm i https://pkg.pr.new/@vue/runtime-dom@14193

yarn add https://pkg.pr.new/@vue/[email protected]

@vue/runtime-vapor

pnpm add https://pkg.pr.new/@vue/runtime-vapor@14193

npm i https://pkg.pr.new/@vue/runtime-vapor@14193

yarn add https://pkg.pr.new/@vue/[email protected]

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14193

npm i https://pkg.pr.new/@vue/server-renderer@14193

yarn add https://pkg.pr.new/@vue/[email protected]

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14193

npm i https://pkg.pr.new/@vue/shared@14193

yarn add https://pkg.pr.new/@vue/[email protected]

vue

pnpm add https://pkg.pr.new/vue@14193

npm i https://pkg.pr.new/vue@14193

yarn add https://pkg.pr.new/[email protected]

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14193

npm i https://pkg.pr.new/@vue/compat@14193

yarn add https://pkg.pr.new/@vue/[email protected]

commit: c7e7415

Copilot AI reviewed Dec 12, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes parent instance capturing for dynamic fragments by moving the capture logic from render time to construction time. This ensures correct parent instance resolution, especially in KeepAlive scenarios where components are cached and reused.

  • Captures parent component instance in DynamicFragment constructor using getScopeOwner()
  • Removes instance parameter from renderBranch method, simplifying the API
  • Skips withVaporCtx wrapping for KeepAlive slot content in the compiler

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/runtime-vapor/src/fragment.ts Captures parent component at construction time in DynamicFragment and refactors renderBranch to use stored parent instance
packages/compiler-vapor/src/generators/component.ts Adds KeepAlive check to skip unnecessary withVaporCtx wrapping for KeepAlive slot content

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@edison1105 edison1105 force-pushed the edison/fix/transition branch from 0f33a7b to 542e0c8 Compare December 12, 2025 02:05
@edison1105 edison1105 changed the title fix(runtime-vapor): properly capturing parent instance for dynamic fragment fix(runtime-vapor): track and restore slot owner context for VaporFragment rendering Dec 12, 2025
@edison1105 edison1105 changed the title fix(runtime-vapor): track and restore slot owner context for VaporFragment rendering fix(runtime-vapor): track and restore slot owner context for DynamicFragment rendering Dec 12, 2025
@edison1105 edison1105 linked an issue Dec 12, 2025 that may be closed by this pull request
[Vapor mode] Modal with Transitions rendering issue #14192
Closed
@edison1105 edison1105 force-pushed the edison/fix/transition branch 2 times, most recently from f0c529a to 5e2af2d Compare December 12, 2025 02:56
@edison1105 edison1105 force-pushed the edison/fix/transition branch from 5e2af2d to 809c494 Compare December 12, 2025 03:05
@edison1105 edison1105 merged commit 79aa9db into minor Dec 12, 2025
22 of 23 checks passed
@edison1105 edison1105 deleted the edison/fix/transition branch December 12, 2025 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Vapor mode] Modal with Transitions rendering issue

2 participants

@edison1105