feat(reactivity): computed side effects no longer trigger scheduler#10232
Merged
Conversation
Size ReportBundles
Usages
|
Member
Author
|
/ecosystem-ci run |
johnsoncodehk
changed the title
computed side effects no longer trigger scheduler
Contributor
|
📝 Ran ecosystem CI: Open
|
Member
|
Highly agree with warning users when |
Member
|
I agree such cases should definitely throw warnings, whether we can remove it in the next minor is questionable, as such misuse seems to be prevalent in userland, especially Vue 2 codebases migrating to Vue 3. |
n0099
added a commit
to n0099/open-tbm
that referenced
this pull request
Feb 9, 2024
…eir assumed fix vuejs/core#10232 $ yarn remove {,@types}lodash $ yarn add {,@types}lodash-es * move packages `@tanstack/{eslint-plugin-query,vue-query-devtools}` & `@types/lodash-es` to `devDependencies` section @ package.json @ fe
Member
|
I committed a PR for warning users stuff |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #10214
This PR introduces a special state
MaybeDirty_ComputedSideEffectto avoid computed side effects triggering effect/watch/render callbacks.Although this workaround is to solve the regressions introduced by the new Reactivity System, I think this is not the accurate behavior. The reproduction of #10214 (and related issues) should indeed cause an infinite loop. I recommend throwing a warning for the case where computed produces side effects. And remove the
MaybeDirty_ComputedSideEffectworkaround in 3.5.Blocking by #10187