fix(effect): computed lost reactivity#10119
Merged
Merged
Conversation
Size ReportBundles
Usages
|
Member
Author
|
@yyx990803 @LinusBorg Could you help to invoke the |
Member
|
/ecosystem-ci run |
Member
|
|
Doctor-wu
changed the title
Contributor
|
📝 Ran ecosystem CI: Open
|
Member
|
Looks like the quasar fail is a flaky transition test. Re-running to be sure. |
Member
Author
|
The test seems to have passed, but the comment update failed😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #10114
This PR will re-introduce the problem of #10085, #10090, but the
computedwould not lose reactivityI think this might be a trade-off in short term.