fix(reactivity): mark the effect as recursive if there's updates during the run#10090
Closed
pikax wants to merge 1 commit into
Closed
fix(reactivity): mark the effect as recursive if there's updates during the run#10090pikax wants to merge 1 commit into
pikax wants to merge 1 commit into
Conversation
pikax
added
the
🔥 p5-urgent
Size ReportBundles
Usages
|
Member
|
Maybe properly fixed in #10091 |
yyx990803
removed
the
🔥 p5-urgent
Member
|
I'm not sure if this is something we should account for (mutating state in a computed getter) as this is something we explicitly warn people against in the docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #10082
The test that fixes #2043 is contradicting this PR, not sure if the #2043 should be handle differently