@@ -92,6 +92,50 @@ describe('vnode', () => {
9292 expect ( `VNode created with invalid key (NaN)` ) . toHaveBeenWarned ( )
9393 } )
9494
95+ // #5081
96+ describe ( 'children overridden by innerHTML / textContent' , ( ) => {
97+ test ( 'warn on text children' , ( ) => {
98+ createVNode ( 'div' , { innerHTML : '<span/>' } , 'hello' )
99+ expect (
100+ `The \`innerHTML\` prop on <div> will override its children` ,
101+ ) . toHaveBeenWarned ( )
102+ } )
103+
104+ test ( 'warn on array children' , ( ) => {
105+ createVNode ( 'div' , { innerHTML : '<span/>' } , [ createVNode ( 'span' ) ] )
106+ expect (
107+ `The \`innerHTML\` prop on <div> will override its children` ,
108+ ) . toHaveBeenWarned ( )
109+ } )
110+
111+ test ( 'warn on textContent' , ( ) => {
112+ createVNode ( 'div' , { textContent : 'text' } , 'hello' )
113+ expect (
114+ `The \`textContent\` prop on <div> will override its children` ,
115+ ) . toHaveBeenWarned ( )
116+ } )
117+
118+ test ( 'no warning when the prop is nullish' , ( ) => {
119+ createVNode ( 'div' , { innerHTML : undefined } , 'hello' )
120+ createVNode ( 'div' , { innerHTML : null } , 'hello' )
121+ createVNode ( 'div' , { textContent : undefined } , 'hello' )
122+ expect ( `will override its children` ) . not . toHaveBeenWarned ( )
123+ } )
124+
125+ test ( 'no warning without renderable children' , ( ) => {
126+ createVNode ( 'div' , { innerHTML : '<span/>' } )
127+ createVNode ( 'div' , { innerHTML : '<span/>' } , '' )
128+ createVNode ( 'div' , { innerHTML : '<span/>' } , [ ] )
129+ expect ( `will override its children` ) . not . toHaveBeenWarned ( )
130+ } )
131+
132+ test ( 'no warning for component vnodes' , ( ) => {
133+ const Comp = { props : [ 'innerHTML' ] , render : ( ) => null }
134+ createVNode ( Comp , { innerHTML : '<span/>' } , { default : ( ) => 'slot' } )
135+ expect ( `will override its children` ) . not . toHaveBeenWarned ( )
136+ } )
137+ } )
138+
95139 test ( 'create with class component' , ( ) => {
96140 class Component {
97141 $props : any
0 commit comments