feat: proxyRefs method and ShallowUnwrapRefs type
#456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: template auto ref unwrapping are now applied shallowly, i.e. only at the root level. See vuejs/core#1682 for more details.
pikax
commented
Aug 4, 2020
| expect(warn).not.toHaveBeenCalled() | ||
| expect(vm.$el.textContent).toBe('42') | ||
| }) | ||
| // it('not warn doing toRef on props', async () => { |
Member
Author
There was a problem hiding this comment.
this is caused because the props are marked as raw
Open for suggestions
Member
There was a problem hiding this comment.
Guess we can mark the props to shallow reactive and change the test to only tests the top-level toRefs, just like you mentioned in the limitation part?
Member
Author
There was a problem hiding this comment.
Props are already reactive, only the nested ref are not
composition-api/test/setup.spec.js
Lines 336 to 371 in 030d02c
Member
There was a problem hiding this comment.
I think it's fine by leaving a note in the limitation for this.
antfu
reviewed
Aug 6, 2020
antfu
reviewed
Aug 6, 2020
Co-authored-by: Anthony Fu <[email protected]>
Co-authored-by: Anthony Fu <[email protected]>
antfu
reviewed
Aug 6, 2020
antfu
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vuejs/core#1682