Skip to content

Conversation

@Mokkapps
Copy link
Collaborator

No description provided.

@Flowko Flowko self-assigned this Jan 31, 2024
@Flowko Flowko added the enhancement New feature or request label Jan 31, 2024
@Flowko Flowko assigned Mokkapps and unassigned Flowko Jan 31, 2024
@Flowko Flowko self-requested a review January 31, 2024 10:39
Copy link
Member

@Flowko Flowko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! for later we could try to integrate https://shiki.style/packages/transformers for easy use, as it doesnt require extra props, but just updates on the code level, but its missing styles, we can export them from one of vite docs or something

@Flowko Flowko merged commit 25ebf64 into vue-email:main Jan 31, 2024
@Mokkapps Mokkapps deleted the feature/code-block-line-highlighting branch January 31, 2024 10:44
@Mokkapps
Copy link
Collaborator Author

Looks good! for later we could try to integrate https://shiki.style/packages/transformers for easy use, as it doesnt require extra props, but just updates on the code level, but its missing styles, we can export them from one of vite docs or something

Yes, good idea.

I tried to integrate the official transformerNotationHighlight transformer but it only adds the highlight class to the line. I didn't find a way to dynamically bind styles from props to this CSS class.

@Flowko
Copy link
Member

Flowko commented Jan 31, 2024

yeah, true, its kinda the same as doing it manually, but we can improve on it later, this is fine for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants