Repository navigation
Conversation
New sessions select the first model picker option, which previously overrode the resolved CLI, environment, or provider default. Put the resolved default first and include custom model IDs while preserving built-in labels. Add nine regression cases and document precedence. Validated on Linux across Python 3.10-3.13: 2,852 tests per version and 100% configured statement and branch coverage. make all, MyPy, docs, fresh install, and changed-file pre-commit hooks pass. Fixes vstorm-co#250
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The ACP entry point always initialized sessions with the first hard-coded
Anthropic picker option, overriding
--model,PYDANTIC_DEEP_MODEL, and providerauto-detection. Put the resolved default first so the picker and agent factory
use the configured model, including custom model IDs.
Changes
agent creation during prompts, and new sessions after a model switch.
Testing
make allon Linux with Python 3.12.Against the original entry point, eight of the nine regression cases fail
because sessions always select
anthropic:claude-opus-4-6. With the fix, allnine cases pass, including the reported
openai-chat:deepseek-chatscenario.Related Issues
Fixes #250
Notes for Reviewers
The all-file pre-commit run also fails on the original revision because of
existing formatting and spelling problems in unchanged files, including saved
research sessions. Changed-file hooks pass.
The change is reversible and affects ACP startup model selection and picker
ordering. GitHub Actions results will be available after the PR is opened.