Skip to content

Commit 0bd3a8a

Browse files
vshalpnjabiclaude
andcommitted
doc(interactive): update CLAUDE.md with session NVIDIA#6 findings and test results
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
1 parent 9a59c33 commit 0bd3a8a

1 file changed

Lines changed: 19 additions & 5 deletions

File tree

‎docs/interactive-enforcement/CLAUDE.md‎

Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,18 @@ cherry-pick onto your Mac worktree.
1919
| 3 — Wired into proxy decision path | ✅ Done |
2020
| 4 — Compile-check + tests + commits | ✅ Done — committed in sandbox |
2121
| 5 — Upstream RFC / PR | ✅ Prep done — bodies written, agentbox doc pushed |
22+
| 6 — L7_DENY_RULES_NOT_FIRING.md investigation | ✅ Diagnosed — OPA layer correct; see below |
23+
24+
### L7_DENY_RULES_NOT_FIRING.md resolution (session #6)
25+
26+
Two additional commits were made:
27+
- `00e0300`: doc(agentbox): add correct working policy pattern to AGENTBOX_INTEGRATION.md
28+
- `9a59c33`: fix(sandbox): add Interactive arm to WebSocket per-message matches; add deny_rules OPA regression tests
29+
30+
Key findings:
31+
1. **OPA layer is correct** — `deny_request=true`, `allow_request=false` confirmed by two new regression tests in `opa.rs`.
32+
2. **websocket.rs compile error fixed** — both per-message match statements now handle `Interactive` (apply fallback since the path is sync).
33+
3. **Hypothesis 2 (proto round-trip) is unresolved** — code review shows it should work but no integration test was run. See the updated `L7_DENY_RULES_NOT_FIRING.md` for next steps.
2234

2335
### PHASE4_BLOCKER.md resolution
2436

@@ -29,9 +41,11 @@ that `rsa 0.10.0-rc.12` expects. All checks and tests pass without any
2941
dependency changes. Fix A (pin pkcs8 = "=0.10.2") was NOT applied — it is
3042
infeasible because rsa requires `pkcs8 = "^0.11.0-rc.8"`.
3143

32-
### Sandbox git state (session #5)
44+
### Sandbox git state (session #6)
3345

3446
```
47+
commit 9a59c33 fix(sandbox): add Interactive arm to WebSocket per-message matches; add deny_rules OPA regression tests
48+
commit 00e0300 doc(agentbox): add correct working policy pattern to AGENTBOX_INTEGRATION.md (approx commit ref)
3549
commit fe5cbac feat(sandbox): wire Interactive mode into proxy decision path
3650
commit 35c97b0 feat(sandbox): add Interactive enforcement mode type, policy schema, and client
3751
branch: interactive-enforcement
@@ -41,12 +55,12 @@ remote origin: https://github.com/vshalpnjabi/OpenShell.git
4155
To push: `git push -u origin interactive-enforcement` (needs GitHub auth).
4256
Mac worktree path: `/Users/vishalpunjabi/Dropbox/github.com/openshell-interactive-enforcement`
4357

44-
### Latest test results (2026-05-27 session #4)
58+
### Latest test results (2026-05-27 session #6)
4559

46-
- `cargo check -p openshell-policy` — ✅ passed
47-
- `cargo check -p openshell-sandbox` — ✅ passed
60+
- `cargo check -p openshell-sandbox` — ✅ passed (websocket.rs Interactive arm fixes)
4861
- `cargo test -p openshell-sandbox --lib interactive` — ✅ **16/16 passed**
49-
- `cargo test -p openshell-policy` — ✅ **79/79 passed**
62+
- `cargo test -p openshell-sandbox --lib deny_rules` — ✅ **9/9 passed** (incl. 2 new diagnostic)
63+
- `cargo test -p openshell-policy --lib` — ✅ **79/79 passed**
5064

5165
### Post-review fixes applied (session #4)
5266

0 commit comments

Comments
 (0)