Conversation
dhollinger
force-pushed
the
mvc_rework
branch
from
eed189b to
5e8bf8f
Compare
| @@ -0,0 +1,21 @@ | |||
| development: | |||
There was a problem hiding this comment.
TODO: Remove this from the repository.
dhollinger
force-pushed
the
mvc_rework
branch
from
99e310b to
6e754e6
Compare
Gemfile
Outdated
| @@ -1,3 +1,31 @@ | |||
| source 'https://rubygems.org' | |||
| source 'http://rubygems.org' | |||
There was a problem hiding this comment.
Can you change it back to https?
CONTRIBUTORS
Outdated
| Ewoud Kohl van Wijngaarden [email protected] | ||
| Lee Lowder [email protected] | ||
| Tim Meusel [email protected] | ||
| Will Berman [email protected] No newline at end of file |
There was a problem hiding this comment.
I would like to see a newline here
| @@ -0,0 +1,215 @@ | |||
| GIT | |||
There was a problem hiding this comment.
I'm not sure, do we want to comit the Gemfile? We have it in the .gitignore for our modules.
There was a problem hiding this comment.
For web applications like Sinatra and Rails it is considered best practice to include the Gemfile.lock. In fact, the only time you're not supposed to include the Gemfile.lock is for Puppet modules and Rubygems.
| logger.warn('APP_CONFIG.slack_emoji is deprecated and will be removed in puppet_webhook 3.0.0') | ||
| APP_CONFIG.chatops_options[:icon_emoji] = APP_CONFIG.slack_emoji | ||
| logger.warn('APP_CONFIG.slack_proxy_url is deprecated and will be removed in puppet_webhook 3.0.0') | ||
| APP_CONFIG.chatops_options[:http_options] = if APP_CONFIG.slack_proxy_url |
There was a problem hiding this comment.
I was never a real fan of this indentation, but rubocop prefers it.
There was a problem hiding this comment.
mhm, thinking about it. Would this work as well?
| APP_CONFIG.chatops_options[:http_options] = if APP_CONFIG.slack_proxy_url | |
| APP_CONFIG.chatops_options[:http_options] = APP_CONFIG.slack_proxy_url == ture ? slack_proxy : {} |
| allow_uppercase: true | ||
| command_prefix: 'umask 0022;' | ||
|
|
||
| test: &development No newline at end of file |
There was a problem hiding this comment.
please add the missing newline
| def initialize(agent, command, timeouts = nil, options = nil, nodes = [], **args) # rubocop:disable Metrics/ParameterLists | ||
| @agent = agent | ||
| @command = command | ||
| @timeout = timeouts[:timeout] || '120' |
There was a problem hiding this comment.
can this be an integer? (same for dtimeout
There was a problem hiding this comment.
I don't remember the reasons for this. It may be that the MCollective client expects a string. I'll look into it. Could be a 2.0.0 work.
All API routes have been moved to controllers in Api::V1::<ControllerName>. These controllers are configured to respond to their original urls for backwards compatibility. This compatibility will be removed in 2.0.0. All r10k helpers have been moved to a new R10kHelpers file in `app/helpers/r10k_helpers.rb`. All global controller methods are now private methods within the main ApplicationController, while controller-specific methods now exist in their controllers. Any non-public method is now private. All library-based code is now contained in a `PuppetWebhook` module within the `lib/` directory in the root of the codedir. Theses include body parsers, mcollective client, and chatops clients. New tests have been added for the parsers, controllers, and helpers
3 participants
Rework the application into a Model, View, Controller style framework without changing user-facing functionality.
Benefits:
Drawbacks: