This repository was archived by the owner on Jan 29, 2022. It is now read-only.
Merged
Conversation
dhollinger
force-pushed
the
slack_as_plugin
branch
from
c8dedf4 to
016514e
Compare
dhollinger
force-pushed
the
slack_as_plugin
branch
from
016514e to
0dcd860
Compare
dhollinger
force-pushed
the
slack_as_plugin
branch
from
0dcd860 to
dd9c973
Compare
dhollinger
force-pushed
the
slack_as_plugin
branch
from
d6c9970 to
635d2c5
Compare
ekohl
suggested changes
May 1, 2018
lib/helpers/tasks.rb
Outdated
| @@ -65,59 +65,46 @@ def generate_types(environment) | |||
| notify_slack(status_message) if slack? | |||
Member
There was a problem hiding this comment.
This (and line 61) should be notification()
Member
Author
There was a problem hiding this comment.
Nice catch! I'll take care of that.
ekohl
reviewed
May 1, 2018
lib/plugins/chatops/slack.rb
Outdated
| when 202 | ||
| message.merge!( | ||
| color: 'good', | ||
| text: "Successfully deployed #{target}", |
Member
There was a problem hiding this comment.
202 is technically just forked and can still fail. Should this be Deployment started?
bastelfreak
approved these changes
May 1, 2018
ekohl
approved these changes
May 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build plugin for Chatops tools to replace the
notify_methods within the helpers.Still a work in progress. Initial support being built for Slack.
Next PR will support Rocket.chat to bring the app in-line with the
puppet-r10kscript.