Repository navigation
bench: size the decimal kernel benchmarks by bytes rather than rows - #9980
Merged
Merged
Conversation
Merging this PR will not alter performance
|
Signed-off-by: Connor Tsui <[email protected]>
connortsui20
force-pushed
the
ct/beautiful-maxwell-7eyyvp
branch
from
September 22, 2026 19:46
c5811cc to
99dadb0
Compare
mhk197
approved these changes
Sep 22, 2026
robert3005
approved these changes
Sep 22, 2026
Signed-off-by: Connor Tsui <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The decimal kernel benchmarks landed with a 1,024 row case. For
i128that runs in 0.4 to 1.2 µson the walltime legs, below what those machines resolve, so it reports mostly jitter: it moved by
10 to 19% on ten of the last thirteen CodSpeed reports, every one of them on a pull request that
touched no decimal code. No 8,192 row case and no
i256case has moved in those reports.Changes
Derive each kernel case's row count from a working set of 256 KiB and 1 MiB of input plus output,
rather than fixing it at 1,024 and 8,192 rows:
i128i256Both widths now do comparable work, every case takes several microseconds instead of fractions of
one, and the largest still fits the 1 MiB L2 cache of the Graviton leg, so these stay measurements
of kernel code rather than of memory bandwidth.
The array benchmarks in the same files are
#[cfg(not(codspeed))]and never run in CI, so theykeep their sizes for quick local runs. The benchmarking guide gains the measured walltime floor
next to the simulation floor documented in #9951.
Expect a one-time batch of CodSpeed rows for these eight cases when this merges, since the inputs
change size.
Checked with
cargo clippy -p vortex-decimal-byte-parts --all-targets --all-features -- -D warningsand
cargo fmt. No benchmarks were run locally: this session is a shared cloud VM, so its walltimenumbers would not mean anything.
🤖 Generated with Claude Code
https://claude.ai/code/session_01B6ApyxEXpjiasZbQptsypn
Generated by Claude Code