Skip to content

Port Sparse sum to SumV2 - #9622

Merged
robert3005 merged 1 commit into
developfrom
mk/sparse-sum-v2
Sep 21, 2026
Merged

Port Sparse sum to SumV2#9622
robert3005 merged 1 commit into
developfrom
mk/sparse-sum-v2

Conversation

@mhk197

@mhk197 mhk197 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Port the Sparse aggregate pushdown to SumV2 while preserving SQL semantics for all-null input.

Changes

  • register the Sparse aggregate kernel for SumV2
  • construct the bound aggregate accumulator so Sum and SumV2 retain their respective partial-state, overflow, and NaN semantics
  • add direct registered-kernel tests for non-empty and all-null Sparse arrays

@codspeed

codspeed Bot commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will degrade performance by 19.61%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 1 improved benchmark
❌ 5 regressed benchmarks
✅ 2247 untouched benchmarks
⏩ 218 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ WallTime arrow_checked_add_u32_neon[16384] 12.3 µs 20.3 µs -39.29%
❌ Simulation decode_primitives[f32, (1000, 512)] 42 µs 64.1 µs -34.49%
❌ Simulation take_map[(0.1, 0.5)] 155.8 µs 191.3 µs -18.57%
❌ Simulation take_map[(0.1, 1.0)] 229.3 µs 269.4 µs -14.87%
❌ WallTime words_gather_scalar_avx2[65536] 8.2 µs 9.3 µs -11.84%
⚡ WallTime mul_i32_nonnull_avx512 7.9 µs 7.1 µs +11.01%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

Comparing mk/sparse-sum-v2 (01d216c) with develop (f5b3b26)

Open in CodSpeed

Footnotes

  1. 218 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@mhk197
mhk197 force-pushed the mk/sparse-sum-v2 branch 3 times, most recently from 4714f8c to 1321345 Compare August 25, 2026 19:39
@mhk197 mhk197 added the changelog/chore A trivial change label Aug 27, 2026
@mhk197
mhk197 marked this pull request as ready for review August 27, 2026 16:12
@mhk197 mhk197 changed the title Port Sparse sum to SumV2 Port Sparse sum to SumV2 Aug 27, 2026
@mhk197
mhk197 marked this pull request as draft August 27, 2026 16:20
@mhk197
mhk197 marked this pull request as ready for review September 3, 2026 15:26
@mhk197
mhk197 requested a review from robert3005 September 3, 2026 15:26
@mhk197 @claude
replace
01d216c 
Signed-off-by: Matt Katz <[email protected]>
@robert3005
robert3005 merged commit b0ea625 into develop Sep 21, 2026
92 of 94 checks passed
@robert3005
robert3005 deleted the mk/sparse-sum-v2 branch September 21, 2026 18:37
This was referenced Oct 17, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robert3005 robert3005 robert3005 approved these changes

Assignees

No one assigned

Labels

changelog/chore A trivial change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Port Sparse sum to SumV2

2 participants

@mhk197 @robert3005