Skip to content

Remove unused ArrayRef::is_arrow - #8868

Merged
connortsui20 merged 1 commit into
developfrom
codex/remove-unused-is-arrow
Jul 21, 2026
Merged

Remove unused ArrayRef::is_arrow#8868
connortsui20 merged 1 commit into
developfrom
codex/remove-unused-is-arrow

Conversation

@connortsui20

@connortsui20 connortsui20 commented Jul 20, 2026

Copy link
Copy Markdown
Member

Summary

Testing

  • cargo check -p vortex-array
  • cargo clippy --all-targets --all-features (pre-push hook)

@connortsui20 connortsui20 added the changelog/chore A trivial change label Jul 20, 2026
@github-actions

github-actions Bot commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Polar Signals Profiling Results

Latest Run

Status Commit Job Attempt Link
🟢 Done 87fd36f 1 Explore Profiling Data

Powered by Polar Signals Cloud

@github-actions

github-actions Bot commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Benchmarks: Vortex queries 📖

Verdict: No clear signal (low confidence)
Attributed Vortex impact: +0.5%
Engines: DataFusion No clear signal (+8.1%, medium confidence) · DuckDB No clear signal (-6.5%, medium confidence)
Vortex (geomean): 0.922x ➖
Parquet (geomean): 0.919x ➖
Shifts: Parquet (control) -8.1% · Median polish -7.6%

How to read Verdict and Engines
  • Verdict: Overall PR-level signal after subtracting baseline drift estimated from Parquet control rows. It can be Likely improvement, Likely regression, or No clear signal.
  • Engines: Per-engine attribution. DataFusion is compared against DataFusion/Parquet controls; DuckDB is compared against DuckDB/Parquet controls. This answers whether each engine improved or regressed independently.
  • Confidence: Based on directional consistency, share of rows above the noise floor, and control-run noise.
datafusion / vortex-file-compressed (0.937x ➖, 0↑ 0↓)
name PR 87fd36f (ns) base 5b688a9 (ns) ratio (PR/base)
vortex_q00/datafusion:vortex-file-compressed 9853745 10644295 0.93
vortex_q01/datafusion:vortex-file-compressed 6476957 6830634 0.95
datafusion / parquet (0.867x ✅, 2↑ 0↓)
name PR 87fd36f (ns) base 5b688a9 (ns) ratio (PR/base)
vortex_q00/datafusion:parquet 🚀 20229346 22843824 0.89
vortex_q01/datafusion:parquet 🚀 4611270 5437392 0.85
duckdb / vortex-file-compressed (0.911x ➖, 1↑ 0↓)
name PR 87fd36f (ns) base 5b688a9 (ns) ratio (PR/base)
vortex_q00/duckdb:vortex-file-compressed 10346485 10947785 0.95
vortex_q01/duckdb:vortex-file-compressed 🚀 6111407 6952563 0.88
duckdb / parquet (0.975x ➖, 0↑ 0↓)
name PR 87fd36f (ns) base 5b688a9 (ns) ratio (PR/base)
vortex_q00/duckdb:parquet 23524138 24229204 0.97
vortex_q01/duckdb:parquet 9539607 9746132 0.98

No file size changes detected.

@connortsui20

connortsui20 commented Jul 20, 2026

Copy link
Copy Markdown
Member Author

Closing this because it was created in the wrong task context; the original stacked PR state has been restored.

@connortsui20
connortsui20 deleted the codex/remove-unused-is-arrow branch July 20, 2026 22:21
@connortsui20
connortsui20 restored the codex/remove-unused-is-arrow branch July 20, 2026 22:45
@connortsui20

connortsui20 commented Jul 20, 2026

Copy link
Copy Markdown
Member Author

oh codex decided to delete this for some reason

@connortsui20 connortsui20 reopened this Jul 20, 2026
@connortsui20
connortsui20 enabled auto-merge (squash) July 20, 2026 22:45
@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.08%. Comparing base (2ea51cb) to head (87fd36f).
⚠️ Report is 2 commits behind head on develop.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@connortsui20
connortsui20 merged commit 39f4abe into develop Jul 21, 2026
163 of 165 checks passed
@connortsui20
connortsui20 deleted the codex/remove-unused-is-arrow branch July 21, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robert3005 robert3005 robert3005 approved these changes

Assignees

No one assigned

Labels

changelog/chore A trivial change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@connortsui20 @robert3005