Repository navigation
Add stats rewrite session API - #7930
Merged
Merged
Conversation
This was referenced May 14, 2026
gatesn
changed the title
Merging this PR will not alter performance
|
gatesn
force-pushed
the
ngates/stats-7707/stats-rewrite-session-api
branch
from
May 14, 2026 19:54
586a049 to
80f3d5e
Compare
gatesn
force-pushed
the
ngates/stats-7707/null-count-stat-wrappers
branch
from
May 14, 2026 19:54
02d39d4 to
4896ec4
Compare
gatesn
force-pushed
the
ngates/stats-7707/stats-rewrite-session-api
branch
from
May 14, 2026 20:27
80f3d5e to
c3fe2de
Compare
gatesn
force-pushed
the
ngates/stats-7707/null-count-stat-wrappers
branch
from
May 14, 2026 20:27
4896ec4 to
75ba3eb
Compare
gatesn
force-pushed
the
ngates/stats-7707/stats-rewrite-session-api
branch
from
May 14, 2026 21:00
c3fe2de to
4c86e67
Compare
gatesn
force-pushed
the
ngates/stats-7707/null-count-stat-wrappers
branch
from
May 14, 2026 21:00
75ba3eb to
2839387
Compare
gatesn
force-pushed
the
ngates/stats-7707/stats-rewrite-session-api
branch
from
May 14, 2026 21:05
4c86e67 to
ab2cdbc
Compare
gatesn
force-pushed
the
ngates/stats-7707/null-count-stat-wrappers
branch
from
May 14, 2026 21:05
2839387 to
85a04e0
Compare
gatesn
added a commit
that referenced
this pull request
May 14, 2026
Part of #7707. Base: #7931 Next: #7930 ## Summary - Add a `NullCount` aggregate wrapper and register it in the aggregate function session. - Bridge `Stat::NullCount` through the `Stat` aggregate-function mapping introduced by #7931. - Add stats expression constructors used by the current pruning/stat expression path. ## Checks - `cargo test -p vortex-array null_count` - `cargo test -p vortex-array stat_expr` - `./scripts/public-api.sh` - `cargo clippy --all-targets --all-features` Signed-off-by: Nicholas Gates <[email protected]>
Base automatically changed from
ngates/stats-7707/null-count-stat-wrappers
to
ngates/aggregatefn-stat-bridge-cleanup
May 14, 2026 21:11
gatesn
force-pushed
the
ngates/stats-7707/stats-rewrite-session-api
branch
from
May 14, 2026 21:16
ab2cdbc to
1974b37
Compare
Base automatically changed from
ngates/aggregatefn-stat-bridge-cleanup
to
develop
May 14, 2026 21:26
gatesn
force-pushed
the
ngates/stats-7707/stats-rewrite-session-api
branch
2 times, most recently
from
May 14, 2026 21:29
54f5e31 to
cc8610a
Compare
gatesn
changed the base branch from
develop
to
ngates/stats-7707/null-count-stat-wrappers-v2
May 14, 2026 21:30
Base automatically changed from
ngates/stats-7707/null-count-stat-wrappers-v2
to
develop
May 14, 2026 21:39
gatesn
added a commit
that referenced
this pull request
May 14, 2026
Part of #7707. Replacement for #7929 after the accidental merge was reverted before #7931 landed. Base: `develop` Next: #7930 ## Summary - Add a `NullCount` aggregate wrapper and register it in the aggregate function session. - Bridge `Stat::NullCount` through the `Stat` aggregate-function mapping introduced by #7931. - Add stats expression constructors used by the current pruning/stat expression path. ## Checks - `cargo test -p vortex-array null_count` - `cargo test -p vortex-array stat_expr` - `./scripts/public-api.sh` - `cargo clippy --all-targets --all-features` Signed-off-by: Nicholas Gates <[email protected]>
Signed-off-by: Nicholas Gates <[email protected]>
gatesn
force-pushed
the
ngates/stats-7707/stats-rewrite-session-api
branch
from
May 14, 2026 21:47
cc8610a to
2138a72
Compare
gatesn
changed the title
gatesn
marked this pull request as ready for review
May 14, 2026 23:00
gatesn
enabled auto-merge (squash)
May 14, 2026 23:00
robert3005
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #7707.
Base:
developSummary
vortex-array/src/stats/session.rs.StatsRewriteRuletrait, rewrite context, and session registry.Expression::{falsify,satisfy}as the only public entrypoints for stats-backed proof rewrites.StatsRewriteSessionin the default Vortex session.STYLE.md.Checks
cargo test -p vortex-array stats::rewrite./scripts/public-api.shcargo clippy --all-targets --all-features