Repository navigation
Update flatbuffers generated - #7899
Merged
Merged
Conversation
Signed-off-by: Connor Tsui <[email protected]>
Member
Author
|
This is because of google/flatbuffers#8564 and google/flatbuffers#8828 which is somewhat recent |
Contributor
|
You have to update versions used by CI as well |
connortsui20
marked this pull request as ready for review
May 12, 2026 14:54
connortsui20
enabled auto-merge (squash)
May 12, 2026 14:54
Merging this PR will improve performance by 32.84%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | new_bp_prim_test_between[i64, 16384] |
144.9 µs | 115.7 µs | +25.28% |
| ⚡ | Simulation | new_bp_prim_test_between[i16, 32768] |
134.8 µs | 120.9 µs | +11.46% |
| ⚡ | Simulation | new_bp_prim_test_between[i32, 32768] |
170.3 µs | 141.5 µs | +20.36% |
| ⚡ | Simulation | new_bp_prim_test_between[i64, 32768] |
237.2 µs | 178.6 µs | +32.84% |
| ⚡ | Simulation | new_bp_prim_test_between[i32, 16384] |
109.4 µs | 95.1 µs | +15% |
| ⚡ | Simulation | new_alp_prim_test_between[f64, 16384] |
149.4 µs | 127.6 µs | +17.1% |
Comparing ct/fb-update (ceeeaed) with develop (6f54d3d)
robert3005
reviewed
May 12, 2026
| flatc_version: | ||
| description: "Version of the flatc binary" | ||
| default: "25.9.23" | ||
| default: "25.12.19" |
Contributor
There was a problem hiding this comment.
this doesn't get run on our ami images, you will have to update them and then make a pr. Annoyingly there will be an amount of time when all prs will fail because of it :/
Member
Author
There was a problem hiding this comment.
Signed-off-by: Connor Tsui <[email protected]>
connortsui20
force-pushed
the
ct/fb-update
branch
from
May 12, 2026 16:37
55d296e to
ceeeaed
Compare
Member
Author
robert3005
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I am not sure why but my local flatc produces different results than CI. Do we need to update something?
This happens on both my linux machine and mac.
Testing
N/A