Repository navigation
Tensor Matchers - #7300
Merged
Merged
Tensor Matchers#7300
Conversation
connortsui20
force-pushed
the
ct/vector-match
branch
2 times, most recently
from
April 6, 2026 21:09
d4305ae to
ddf1bb4
Compare
Merging this PR will not alter performance
Comparing 
Footnotes
|
31 of 42 tasks
Signed-off-by: Connor Tsui <[email protected]>
Signed-off-by: Connor Tsui <[email protected]>
connortsui20
force-pushed
the
ct/vector-match
branch
from
April 6, 2026 21:19
ddf1bb4 to
c67a6bd
Compare
gatesn
approved these changes
Apr 6, 2026
3 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tracking issue: #7297
Instead of having weird helper functions extract information out of the FSL dtype, we can extract it into new matcher metadata via
AnyVectorandAnyFixedShapeTensormatchers.Note that this is separate from the metadata that needs to be serialized to disk on the array vtable.
Testing
N/A since the logic should be the same, just in a different place.