Repository navigation
Fix old extension scalar logic - #6701
Merged
Merged
Conversation
connortsui20
commented
Feb 26, 2026
gatesn
reviewed
Feb 27, 2026
gatesn
enabled auto-merge (squash)
February 27, 2026 01:25
gatesn
approved these changes
Feb 27, 2026
connortsui20
commented
Feb 27, 2026
Comment on lines
+214
to
+220
| struct StorageValueDisplay<'a>(&'a dyn DynExtDType, &'a ScalarValue); | ||
|
|
||
| impl fmt::Display for StorageValueDisplay<'_> { | ||
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| self.0.value_display(f, self.1) | ||
| } | ||
| } |
Signed-off-by: Connor Tsui <[email protected]>
Signed-off-by: Connor Tsui <[email protected]>
Signed-off-by: Connor Tsui <[email protected]>
Signed-off-by: Nicholas Gates <[email protected]>
Signed-off-by: Connor Tsui <[email protected]>
connortsui20
force-pushed
the
ct/ext-scalar-logic
branch
from
February 27, 2026 13:21
4742cb1 to
339b687
Compare
fastio
pushed a commit
to fastio/vortex
that referenced
this pull request
Mar 10, 2026
## Summary Tracking Issue: vortex-data#6618 Finally changes the old (incorrect) extension scalar logic to validate and display correctly. We are now at the tail end of implementing extension scalars. ## Testing Adds a few tests to the time extension types to see that validation and displaying works correctly. Also removes a few incorrect tests. --------- Signed-off-by: Connor Tsui <[email protected]> Signed-off-by: Nicholas Gates <[email protected]> Co-authored-by: Nicholas Gates <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tracking Issue: #6618
Finally changes the old (incorrect) extension scalar logic to validate and display correctly. We are now at the tail end of implementing extension scalars.
Testing
Adds a few tests to the time extension types to see that validation and displaying works correctly. Also removes a few incorrect tests.