Repository navigation
Remove vortex-vector - #6529
Merged
Merged
Remove vortex-vector#6529
vortex-vector#6529Conversation
connortsui20
requested review from
a10y,
gatesn,
joseph-isaacs and
robert3005
February 16, 2026 14:30
connortsui20
force-pushed
the
ct/remove-vortex-vector
branch
from
February 16, 2026 14:34
8e34113 to
a76b012
Compare
robert3005
approved these changes
Feb 16, 2026
Signed-off-by: Connor Tsui <[email protected]>
connortsui20
force-pushed
the
ct/remove-vortex-vector
branch
from
February 16, 2026 15:44
a76b012 to
0b4477c
Compare
Merging this PR will improve performance by 11.52%
Performance Changes
Comparing 
Footnotes
|
Member
Author
|
I should point out that I still think it is worth keeping this in our back pocket in case we want to replace our builders with these vectors. With |
Member
Author
|
A moment of silence for |
fastio
pushed a commit
to fastio/vortex
that referenced
this pull request
Mar 10, 2026
😢 We need to remove this now because we want to merge `vortex-dtype` into `vortex-array`, and if this still existed it would create a dependency cycle. ``` vortex-array --(depends on)--> vortex-vector --(depends on)--> vortex-dtype vortex-array <--(depends on)--> vortex-dtype ``` 😭 Signed-off-by: Connor Tsui <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
😢
We need to remove this now because we want to merge
vortex-dtypeintovortex-array, and if this still existed it would create a dependency cycle.😭