Closed
Conversation
CodSpeed Performance ReportMerging #4853 will not alter performanceComparing Summary
|
Adds a `ListViewShape` type to track whether list view data has sorted offsets, overlapping views, or gaps. This enables faster rebuilding and identifies when a `ListView` can be efficiently converted to a regular `List` array. Signed-off-by: Connor Tsui <[email protected]>
Signed-off-by: Connor Tsui <[email protected]>
connortsui20
force-pushed
the
ct/list-view-canonicalize
branch
from
1d23cdd to
14d849a
Compare
Contributor
Author
|
Since we're not merging #4830 and this PR is based on top of that, I'm just going to close this and fix all the conflicts with develop next week so I don't have to keep rebasing |
connortsui20
added a commit
that referenced
this pull request
Oct 16, 2025
Tracking Issue: #4699 Revived from: #4853 and #4830 This PR makes `ListViewArray` the canonical encoding of `DType::List`, which used to be `ListArray`. We will probably have a large regression in term of performance for now, but that can be improved in the future. --------- Signed-off-by: Connor Tsui <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO