Closed
Conversation
connortsui20
force-pushed
the
ct/list-view-builder
branch
from
ed0e7ea to
bcd48ed
Compare
connortsui20
force-pushed
the
ct/list-view-canonicalize
branch
2 times, most recently
from
7d112a5 to
bbaf509
Compare
7 tasks
connortsui20
force-pushed
the
ct/list-view-canonicalize
branch
from
bbaf509 to
727a639
Compare
CodSpeed Performance ReportMerging #4754 will degrade performances by 16.47%Comparing Summary
Benchmarks breakdown
|
connortsui20
force-pushed
the
ct/list-view-canonicalize
branch
from
727a639 to
2e149e8
Compare
connortsui20
added
the
action/benchmark-sql
github-actions
bot
removed
the
action/benchmark-sql
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
connortsui20
force-pushed
the
ct/list-view-canonicalize
branch
from
2e149e8 to
5bd960e
Compare
connortsui20
added
action/benchmark
- implement list view rebuilding - add list view exporter conversion cast - take rebuild optimization - hack for empty export bug Signed-off-by: Connor Tsui <[email protected]>
connortsui20
force-pushed
the
ct/list-view-canonicalize
branch
from
41d9fc3 to
33047a0
Compare
connortsui20
added
action/benchmark
github-actions
bot
removed
action/benchmark-sql
Contributor
Author
|
Since the conversation is getting long and I need to rebase a bunch of stuff I'm closing this and will reopen a fresh PR soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking Issue: #4699
This PR migrates the
Canonical::Listencoding fromListArraytoListViewArray.There were a lot of small things that had to be updated, as well as tests that assumed
ListArraywas the default encoding.Unresolved
Bug in TPC-DS (Failed to downcast) due tolist_containskernel not expecting aListViewArrayencodings/sparse/src/canonical.rsandvortex-array/src/arrays/chunked/decode.rsis correct, so I would appreciate scrutiny on that. (I cleaned it up but also filed Clean upencodings/sparse/src/canonical.rs#4777)takecompute function onListArrayreturn aListViewArray? We might also want to defer this question to the operator changes later. (yes)GenericListArray, not theirGenericListViewArray. There are some tests that rely on this, not sure if should just remove parts of those tests. (ToArrowis now implemented forListArrayListViewneeds to operate well (to make use of the fact that it is a view).