Skip to content

Feature: ListViewBuilder#4738

Merged
connortsui20 merged 3 commits intodevelopfrom
ct/list-view-builder
Sep 25, 2025
Merged

Feature: ListViewBuilder#4738
connortsui20 merged 3 commits intodevelopfrom
ct/list-view-builder

Conversation

@connortsui20
Copy link
Contributor

@connortsui20 connortsui20 commented Sep 23, 2025

Tracking Issue: #4699

Adds ListViewBuilder.

Also cleans up a few other issues from a previous PR.

@connortsui20 connortsui20 added the changelog/feature A new feature label Sep 23, 2025
@connortsui20 connortsui20 mentioned this pull request Sep 23, 2025
Closed
7 tasks
@vortex-data vortex-data deleted a comment from codspeed-hq bot Sep 23, 2025
@codecov
Copy link

codecov bot commented Sep 23, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 90.30100% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.57%. Comparing base (d4f2906) to head (bcd48ed).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-array/src/builders/listview.rs 90.03% 29 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

robert3005
robert3005 requested changes Sep 24, 2025
View reviewed changes
Copy link
Contributor

@robert3005 robert3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a small bug and I left some style comments

@connortsui20 connortsui20 force-pushed the ct/list-view-compute branch 2 times, most recently from 5ff647e to 296806a Compare September 24, 2025 14:52
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 24, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #4738 will not alter performance

Comparing ct/list-view-builder (bcd48ed) with develop (d4f2906)

Summary

✅ 1156 untouched
⏩ 292 skipped1

Footnotes

  1. 292 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Base automatically changed from ct/list-view-compute to develop September 24, 2025 22:16
@robert3005
Copy link
Contributor

robert3005 commented Sep 24, 2025

I think you still want to rebase it before merging it

@connortsui20
add ListViewBuilder
b4676fe 
Signed-off-by: Connor Tsui <[email protected]>
@connortsui20
add tests
00d1fa3 
Signed-off-by: Connor Tsui <[email protected]>
@connortsui20
clean up issues
bcd48ed 
Signed-off-by: Connor Tsui <[email protected]>
@connortsui20 connortsui20 merged commit e1f043d into develop Sep 25, 2025
37 checks passed
@connortsui20 connortsui20 deleted the ct/list-view-builder branch September 25, 2025 13:30
blaginin pushed a commit that referenced this pull request Sep 29, 2025
@connortsui20 @blaginin
Feature: ListViewBuilder (#4738)
51271b0 
Tracking Issue: #4699

Adds `ListViewBuilder`.

Also cleans up a few other issues from a previous PR.

---------

Signed-off-by: Connor Tsui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robert3005 robert3005 robert3005 approved these changes

@joseph-isaacs joseph-isaacs Awaiting requested review from joseph-isaacs

@gatesn gatesn Awaiting requested review from gatesn

Assignees

No one assigned

Labels

changelog/feature A new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@connortsui20 @robert3005