Skip to content

Feature: Add FixedSizeListBuilder - #4428

Merged
connortsui20 merged 4 commits into
developfrom
connor/fsl-builder
Aug 29, 2025
Merged

Feature: Add FixedSizeListBuilder#4428
connortsui20 merged 4 commits into
developfrom
connor/fsl-builder

Conversation

@connortsui20

@connortsui20 connortsui20 commented Aug 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Tracking Issue: #4372

Adds support for FixedSizeListBuilder: ArrayBuilder. I don't actually use the builder where it needs to be yet, but I am going to leave that for a followup PR.

Additionally adds unit tests for the builder, making sure to test the degenerate cases.

Also note that some of the TODOs with respect to the append_zero and append_nulls will be solved in the next PR I do so don't worry too much about those...

@connortsui20
implement FixedSizeListBuilder
cb5ff5c 
Signed-off-by: Connor Tsui <[email protected]>
@connortsui20
add some todos for later
1f9758e 
Signed-off-by: Connor Tsui <[email protected]>
@connortsui20
add FixedSizeListBuilder tests
2f30ec9 
Additionally fixes a null / zero value bug.

Signed-off-by: Connor Tsui <[email protected]>
@connortsui20 connortsui20 added the changelog/feature A new feature label Aug 29, 2025
joseph-isaacs
joseph-isaacs reviewed Aug 29, 2025
View reviewed changes
Comment thread vortex-array/src/builders/primitive.rs Resolved
@codspeed

codspeed Bot commented Aug 29, 2025 •
edited
Loading

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #4428 will not alter performance

Comparing connor/fsl-builder (a994fd2) with develop (5573557)

Summary

✅ 1351 untouched benchmarks

joseph-isaacs
joseph-isaacs reviewed Aug 29, 2025
View reviewed changes
Comment thread vortex-array/src/builders/fixed_size_list.rs Resolved
Comment thread vortex-array/src/builders/fixed_size_list.rs Resolved
Comment thread vortex-array/src/builders/list.rs Resolved
@codecov

codecov Bot commented Aug 29, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.68504% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.57%. Comparing base (811190a) to head (a994fd2).
⚠️ Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-array/src/builders/fixed_size_list.rs 93.46% 27 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@connortsui20
update tests to actually check the values
a994fd2 
And update some TODOs.

Signed-off-by: Connor Tsui <[email protected]>
@connortsui20
connortsui20 merged commit c5415c2 into develop Aug 29, 2025
@connortsui20
connortsui20 deleted the connor/fsl-builder branch August 29, 2025 15:59
@connortsui20 connortsui20 mentioned this pull request Aug 28, 2025
Closed
13 of 15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joseph-isaacs joseph-isaacs joseph-isaacs approved these changes

Assignees

No one assigned

Labels

changelog/feature A new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@connortsui20 @joseph-isaacs