Repository navigation
Feature: Add DType::FixedSizeList variant - #4371
Merged
Merged
Conversation
connortsui20
changed the title
DType::FixedSizeList variantDType::FixedSizeList variant
Adds the variant `DType::FixedSizeList`, but without most of the implementations. The `unimplemented!`s and `TODO(connor)[FixedSizeList]` will be fixed in later PRs. Signed-off-by: Connor Tsui <[email protected]>
connortsui20
force-pushed
the
connor/dtype-fixed-size-list
branch
from
August 26, 2025 10:39
4e9ebcd to
3d79f9a
Compare
robert3005
approved these changes
Aug 26, 2025
13 of 15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking Issue: #4372
Adds the variant
DType::FixedSizeList, but without most of the implementations. Theunimplemented!s andTODO(connor)[FixedSizeList]will be fixed in later PRs.Also fixes a bug and incorrect tests with
list_emptyinvortex-scalar, where creating an empty list made a null scalar.Finally, adds some more casting tests in
vortex-scalar(which found a bug invortex-scalar/src/scalar.rswhere the logic did not work for nested scalars).(Tracking Issue incoming soon)