Repository navigation
fix(layout): normalize rebuilt ListView children before writing - #11371
Merged
robert3005 merged 2 commits intoNov 10, 2026
Merged
robert3005 merged 2 commits into
robert3005 merged 2 commits into
Conversation
Signed-off-by: Christopher Wirt <[email protected]>
robert3005
approved these changes
Nov 10, 2026
robert3005
enabled auto-merge (squash)
November 10, 2026 11:22
Contributor
|
you need to fix fmt, otherwise this is good to merge |
Signed-off-by: Christopher Wirt <[email protected]>
auto-merge was automatically disabled
November 10, 2026 15:24
Head branch was pushed to by a user without write access
robert3005
enabled auto-merge (squash)
November 10, 2026 15:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11370.
Writing sliced
ListViewArraychunks throughListLayoutStrategycan fail withArray vortex.slice is not registered for serialization. Rebuilding the view can leave a lazy elements slice, which is passed directly to the child writer.The ListArray path already normalizes its children with
reset_offsets. This applies the same normalization after rebuilding a ListView, so its elements can be serialized too.Changes
ListDataParts. Ports the QC fix.sliced_list_chunks_round_trip, and add a non-nullable case. Both cases split at rows[1, 3]and check the round-trip values and nulls.Testing
The nullable ListView case exposed the serialization failure in the QC fork; #11370 links the failing CI job. The restored regression has not been run on this upstream port. No tests, builds, lint or formatting commands were run.
AI assistance
Codex helped prepare the upstream port, regression coverage and PR description. I am the responsible contributor.