Repository navigation
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several distinct
list_transformlambdas over one list, or a lambda beside the list read whole, go into one elements read. The elements reader packs one value per lambda, plus the raw element when needed, and the lists come back as a struct of lists sharing the offsets and validity. Over the whole stack, the microbench geomean of 112 cases is 0.65x of develop.Changes
split_list_transform(list/expr.rs): packs the bodies as"0","1", ... and rewrites each use to its list.lists_over(list/reader.rs): one list per pack field, extracted lazily from the packed elements.Testing
list_transform_reads_only_what_its_body_uses::two_lambdasnow reads onlyaandf.random_list_uses_match_memorycovers two lambdas besidelist_sum,list_length,is_null, and the whole list.Follow-up
list_transformforis_nullandlist_length.