Repository navigation
Document temporal storage and binary comparison execution - #11099
Merged
Merged
Conversation
connortsui20
enabled auto-merge (squash)
November 2, 2026 14:08
connortsui20
added a commit
that referenced
this pull request
Nov 2, 2026
## Summary - Tracking Issue: #7683. Extension comparisons could compare raw storage on the array path while scalar execution rejected the same operands. Applies one dtype requirement across comparison paths. ## Changes Checks logical dtypes at binding and before comparison fast paths or encoding kernels run. Regression tests cover batch, row, and constant execution, encoded timestamps, and DuckDB filter pushdown through SQL logic tests. Broader documentation is split into #11099. DataFusion literal conversion is handled separately in #11067. Local pre-commit license and formatting checks passed. Tests and benchmarks were not run after the review fixes. Workspace-wide Clippy started through the pre-push hook and was stopped without a result. ## API Changes Comparison operands must have matching logical dtypes, ignoring nullability. Comparisons between an extension and its storage dtype, or between different extension dtypes, now return an error. This includes timestamps with different units or time zones. --------- Signed-off-by: Connor Tsui <[email protected]>
Signed-off-by: Connor Tsui <[email protected]>
connortsui20
force-pushed
the
ct/extension-comparison-docs
branch
from
November 2, 2026 16:51
4ff1da1 to
de80817
Compare
9 tasks done
robert3005
approved these changes
Nov 2, 2026
12 of 49 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the module and helper documentation extracted from #11016 into a separate PR.
Changes
Explains temporal storage, binary function execution, encoded comparisons, and the DuckDB end-to-end tests. Descriptions match current
developbehavior so this PR can merge independently of #11016.Documentation only. No tests, linting, or formatting commands were run for this PR.