Register parent-reduce rules with the session kernels by robert3005 · Pull Request #11092 · vortex-data/vortex

robert3005 · 2026-11-02T12:06:05Z

Parent-reduce rules move from static PARENT_RULES sets on the vtables into the session kernel registry, so the session controls all rules, as it already does for execute-parent kernels.

Changes

Each encoding registers its parent-reduce rules in its initialize function, through ArrayKernels::register_reduce_parent_rule. The registry keys the rules by the parent and child encoding ids. Rules for any scalar function use AnyScalarFn::id.
The optimizer reads only the registry. It skips the children of a parent for which no rule is registered.
ExecutionCtx takes a snapshot of the parent-reduce kernels when it is created, so optimizing with the context does not read the session again.

myrrc

LGTM. Can we please remove extra comments and make the function take an impl ScalarFnVtable instead of an Id so we'd have typecheck

Each encoding now registers its parent-reduce rules with the session's ArrayKernels through register_reduce_parent_rule, keyed by the parent and child encoding ids, in place of a static PARENT_RULES set on its vtable. Rules for any scalar function are keyed by AnyScalarFn::id. The vtable reduce_parent hook and ParentRuleSet are removed. The optimizer consults only the registry and skips the children of a parent that no rule is registered for. An ExecutionCtx snapshots the parent-reduce kernels when it is created, so optimizing with the context does not read the session again. The shared dictionary values of a chunked array are now pulled up by a chunked reduce rule instead of a dict parent rule. The deprecated session-less optimize now uses only the rules vortex-array registers by default, and it does not mark its result as optimized. Signed-off-by: Robert Kruszewski <[email protected]>

Create one execution context per sample and mark the input arrays as optimized, so the timed loop measures the slice and its reduction rather than the session lookup and the walk over the unmarked input. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Robert Kruszewski <[email protected]>

- register_reduce_parent_rule and register_scalar_fn_reduce_parent_rule take the parent vtable, such as Cast or Filter, instead of its Id. - Remove the doc comments on the register_parent_rules functions. - Keep the parent-reduce and execute-parent kernels each in one ArcSwap of a HashMap with boxed slices. Registration replaces the value with rcu. Signed-off-by: Robert Kruszewski <[email protected]>

Signed-off-by: Robert Kruszewski <[email protected]>

Callers pass each rule as a const { &rule } block, and the registry keeps a &'static dyn reference to it instead of an Arc. Signed-off-by: Robert Kruszewski <[email protected]>

The ALP between rule is now registered with the session, not set on the vtable. The benchmark session did not register ALP, so between decoded the ALP array instead of pushing the bounds into the encoded integers. Signed-off-by: Robert Kruszewski <[email protected]>

robert3005 added this pull request to stack #11093 November 2, 2026 12:06

This was referenced Nov 2, 2026

Record whether an array has been optimized #11089

Merged

Optimize arrays top down as execution reaches them, and retry a parent when its children change #11090

Merged

Deprecate the session-less optimize and keep constructors lazy #11091

Merged

robert3005 added the changelog/break A breaking API change label Nov 2, 2026

robert3005 force-pushed the rk/session-parent-rules branch 2 times, most recently from 1364ff7 to 99ee78b Compare November 2, 2026 12:28

robert3005 force-pushed the rk/session-parent-rules branch 2 times, most recently from be6bdae to 951db46 Compare November 2, 2026 15:11

robert3005 force-pushed the rk/session-parent-rules branch 2 times, most recently from f6a5894 to a564054 Compare November 2, 2026 19:18

robert3005 force-pushed the rk/session-parent-rules branch from a564054 to cc7b45d Compare November 3, 2026 13:16

robert3005 force-pushed the rk/session-parent-rules branch from cc7b45d to 1d85ea1 Compare November 4, 2026 14:31

robert3005 force-pushed the rk/session-parent-rules branch from 1d85ea1 to d493f1f Compare November 4, 2026 15:29

robert3005 force-pushed the rk/session-parent-rules branch from d493f1f to aa27450 Compare November 4, 2026 18:30

robert3005 force-pushed the rk/session-parent-rules branch from aa27450 to 0adc708 Compare November 4, 2026 18:42

robert3005 force-pushed the rk/session-parent-rules branch from 0adc708 to 3894fcb Compare November 4, 2026 19:36

robert3005 force-pushed the rk/session-parent-rules branch from 3894fcb to 5402a3c Compare November 4, 2026 20:06