Repository navigation
Preserve extension literals in DataFusion comparisons - #11067
Merged
Merged
Conversation
connortsui20
added
the
changelog/break
ChatGPT Codex Connector
connortsui20
added a commit
that referenced
this pull request
Oct 30, 2026
The phase graph of the extension plan now shows each PR of phase 0, its state and the order constraints. Phase 1 depends on U4 and U5, and its strict reads wait for the spatial fix. Phase 0 holds #10953, the spatial fix and the importer change, and the structural part of X29 moves out of phase 6. The PR state lists #11013 as merged and adds #11067. In the type roadmap, N6 becomes the storage declaration (X25 to X30), with hard edges from N1 and into N3, and the report matches. Signed-off-by: Connor Tsui <[email protected]>
connortsui20
force-pushed
the
ct/ext-types/datafusion-boundary
branch
from
October 30, 2026 20:51
7443a28 to
7694d56
Compare
connortsui20
commented
Oct 30, 2026
Comment on lines
+145
to
+148
| vortex_bail!( | ||
| "DataFusion ScalarValue requires a dedicated extension representation, got {}", | ||
| self.dtype() | ||
| ); |
Member
Author
There was a problem hiding this comment.
I believe this is the main breaking change, and I think that the current version is just wrong? We can't just pull out the storage scalar.
connortsui20
marked this pull request as ready for review
October 30, 2026 20:57
robert3005
approved these changes
Nov 2, 2026
Base automatically changed from
ct/ext-types/comparison-consistency
to
develop
November 2, 2026 15:56
Signed-off-by: Connor Tsui <[email protected]>
Signed-off-by: Connor Tsui <[email protected]>
Signed-off-by: Connor Tsui <[email protected]>
connortsui20
added a commit
that referenced
this pull request
Nov 2, 2026
## Summary - Tracking Issue: #7683. Extension comparisons could compare raw storage on the array path while scalar execution rejected the same operands. Applies one dtype requirement across comparison paths. ## Changes Checks logical dtypes at binding and before comparison fast paths or encoding kernels run. Regression tests cover batch, row, and constant execution, encoded timestamps, and DuckDB filter pushdown through SQL logic tests. Broader documentation is split into #11099. DataFusion literal conversion is handled separately in #11067. Local pre-commit license and formatting checks passed. Tests and benchmarks were not run after the review fixes. Workspace-wide Clippy started through the pre-push hook and was stopped without a result. ## API Changes Comparison operands must have matching logical dtypes, ignoring nullability. Comparisons between an extension and its storage dtype, or between different extension dtypes, now return an error. This includes timestamps with different units or time zones. --------- Signed-off-by: Connor Tsui <[email protected]>
connortsui20
force-pushed
the
ct/ext-types/datafusion-boundary
branch
from
November 2, 2026 15:56
7694d56 to
4197528
Compare
connortsui20
enabled stacked auto-merge (squash)
November 2, 2026 15:58
Merging this PR will degrade performance by 10.35%1 warning
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing 
|
9 tasks done
connortsui20
added a commit
that referenced
this pull request
Nov 2, 2026
U2, U3, U4, U6, U7 and U8 merged on 2026-11-02 in #11012, #11014 and #11016, and the DataFusion literal fix #11067 merged right after U2. So order constraint 1 holds, and phase 1 starts from develop. The graph shows these nodes as merged, and parts 2 and 4 name the PR that fixed each finding. #10953 now keeps i32 days and widens only the days part to i64 when a value does not fit. It has no review, and it conflicts with the DateTimeParts compare kernel that U2 changed. #11056 still waits on its request for changes. #10661 replaces the closed #10482 for file sort statistics. In the type roadmap, only the N1 sentence changes. Signed-off-by: Connor Tsui <[email protected]>
12 of 49 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Depends on #11016.
DataFusion literals can hold an extension column's Arrow storage value without its extension metadata. Uses the other operand's field metadata to reconstruct Vortex extension scalars, so UUID and JSON filters can still be pushed down with matching dtypes.
Changes
Uses one binary operand conversion path, with field context for comparison literals. Comparison and
IN-list literals use the registered Arrow importer, preserving explicit literal metadata and timestamp units. Inherited extension names and payloads come from the same field, including when the payload is absent, and import errors retain their original cause.Tests cover literal metadata, including stale payloads, static filters, and dynamic filter updates with residual evaluation. Formatting passes with CI's pinned
nightly-2026-09-10forvortex-datafusion. Tests, Clippy, and benchmarks were not run locally for this layer.API Changes
Exporting a non-temporal extension scalar as a bare DataFusion
ScalarValuenow returns an error instead of discarding its extension type. Scalar statistics that cannot preserve the extension type are omitted.