Repository navigation
Require matching dtypes for extension comparisons - #11016
Merged
Merged
Conversation
connortsui20
added
the
changelog/break
ChatGPT Codex Connector
Merging this PR will degrade performance by 15.67%1 warning
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing 
|
connortsui20
marked this pull request as draft
October 29, 2026 22:22
connortsui20
force-pushed
the
ct/ext-types/comparison-consistency
branch
from
October 30, 2026 13:43
2c3048c to
deb59a4
Compare
connortsui20
force-pushed
the
ct/ext-types/comparison-consistency
branch
2 times, most recently
from
October 30, 2026 19:35
b1e9533 to
5bed318
Compare
Signed-off-by: Connor Tsui <[email protected]>
Signed-off-by: Connor Tsui <[email protected]>
connortsui20
force-pushed
the
ct/ext-types/comparison-consistency
branch
from
October 30, 2026 19:45
5bed318 to
2461528
Compare
Signed-off-by: Connor Tsui <[email protected]>
Signed-off-by: Connor Tsui <[email protected]>
Signed-off-by: Connor Tsui <[email protected]>
Signed-off-by: Connor Tsui <[email protected]>
myrrc
requested changes
Nov 2, 2026
myrrc
left a comment
myrrc
left a comment
Contributor
There was a problem hiding this comment.
The general algorithm is fine, but I have two notes:
- Duckdb part should not add any new ifdefs, macros, tweaks, or features unless this is required for building (see static_extensions feature). We also shouldn't write a rust test if we can write an SLT.
- Roughly a third of the changes are comments generated by LLM which are very verbose and IMO don't give you any more information than you'd get reading just the code. I'd propose removing all of them .
| return reinterpret_cast<duckdb_value>(&(*vec)[idx]); | ||
| } | ||
|
|
||
| #ifdef VORTEX_DUCKDB_TEST_HARNESS |
Contributor
There was a problem hiding this comment.
Please don't add ifdefs or macros changing how we run and test duckdb
Member
Author
There was a problem hiding this comment.
How should we test this instead?
Member
Author
There was a problem hiding this comment.
i added sqllogictests, I think this is fine now
Member
Author
|
@myrrc can you tell me which comments you think are not useful? At least for me, I should be able to look at the module docs and not have to read the whole file to understand what it is doing. Generally speaking, if I have to read any code, that is the failure of the docs and the type and function names. We also generally don't have great developer docs, so I try to update these as I make changes (which also helps in keeping them up to date). I'm happy to change docs if you have a better way of summarizing. Note that documentation is not just for the purpose of enhancing what you can understand by manually reading code. |
Member
Author
|
just to make progress, im going to pull the comments out into a separate PR |
Signed-off-by: Connor Tsui <[email protected]>
connortsui20
enabled stacked auto-merge (squash)
November 2, 2026 14:07
myrrc
approved these changes
Nov 2, 2026
connortsui20
added a commit
that referenced
this pull request
Nov 2, 2026
## Summary - Tracking Issue: #7683. Depends on #11016. DataFusion literals can hold an extension column's Arrow storage value without its extension metadata. Uses the other operand's field metadata to reconstruct Vortex extension scalars, so UUID and JSON filters can still be pushed down with matching dtypes. ## Changes Uses one binary operand conversion path, with field context for comparison literals. Comparison and `IN`-list literals use the registered Arrow importer, preserving explicit literal metadata and timestamp units. Inherited extension names and payloads come from the same field, including when the payload is absent, and import errors retain their original cause. Tests cover literal metadata, including stale payloads, static filters, and dynamic filter updates with residual evaluation. Formatting passes with CI's pinned `nightly-2026-09-10` for `vortex-datafusion`. Tests, Clippy, and benchmarks were not run locally for this layer. ## API Changes Exporting a non-temporal extension scalar as a bare DataFusion `ScalarValue` now returns an error instead of discarding its extension type. Scalar statistics that cannot preserve the extension type are omitted. --------- Signed-off-by: Connor Tsui <[email protected]>
9 tasks done
connortsui20
added a commit
that referenced
this pull request
Nov 2, 2026
## Summary Moves the module and helper documentation extracted from #11016 into a separate PR. ## Changes Explains temporal storage, binary function execution, encoded comparisons, and the DuckDB end-to-end tests. Descriptions match current `develop` behavior so this PR can merge independently of #11016. Documentation only. No tests, linting, or formatting commands were run for this PR. Signed-off-by: Connor Tsui <[email protected]>
connortsui20
added a commit
that referenced
this pull request
Nov 2, 2026
U2, U3, U4, U6, U7 and U8 merged on 2026-11-02 in #11012, #11014 and #11016, and the DataFusion literal fix #11067 merged right after U2. So order constraint 1 holds, and phase 1 starts from develop. The graph shows these nodes as merged, and parts 2 and 4 name the PR that fixed each finding. #10953 now keeps i32 days and widens only the days part to i64 when a value does not fit. It has no review, and it conflicts with the DateTimeParts compare kernel that U2 changed. #11056 still waits on its request for changes. #10661 replaces the closed #10482 for file sort statistics. In the type roadmap, only the N1 sentence changes. Signed-off-by: Connor Tsui <[email protected]>
12 of 49 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extension comparisons could compare raw storage on the array path while scalar execution rejected the same operands. Applies one dtype requirement across comparison paths.
Changes
Checks logical dtypes at binding and before comparison fast paths or encoding kernels run. Regression tests cover batch, row, and constant execution, encoded timestamps, and DuckDB filter pushdown through SQL logic tests. Broader documentation is split into #11099. DataFusion literal conversion is handled separately in #11067.
Local pre-commit license and formatting checks passed. Tests and benchmarks were not run after the review fixes. Workspace-wide Clippy started through the pre-push hook and was stopped without a result.
API Changes
Comparison operands must have matching logical dtypes, ignoring nullability. Comparisons between an extension and its storage dtype, or between different extension dtypes, now return an error. This includes timestamps with different units or time zones.