Skip to content

Fix tpchgen-cli for 4.x - #10630

Merged
joseph-isaacs merged 1 commit into
developfrom
rk/sqllogictests
Oct 20, 2026
Merged

joseph-isaacs merged 1 commit into
developfrom
rk/sqllogictests

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Robert Kruszewski <[email protected]>
@robert3005 robert3005 added the changelog/skip Do not list PR in the changelog label Oct 20, 2026
@joseph-isaacs
joseph-isaacs enabled auto-merge (squash) October 20, 2026 09:52

echo "Generating TPC-H data (SF=0.1)..."
uvx tpchgen-cli -s 0.1 --format=parquet --parquet-compression='ZSTD(3)' --output-dir "${DATA_DIR}/"
uvx tpchgen-cli@4.0.0 parquet -s 0.1 --compression='ZSTD(3)' --output-dir "${DATA_DIR}/"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we gen then for benchmark tpch should unify

@codspeed

codspeed Bot commented Oct 20, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 3.74%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ 1 benchmark measured no execution time

Nothing ran under measurement, usually because the compiler removed the code under test. This result is not comparable, so it counts as unchanged.

Preventing compiler optimizations

⚠️ 20 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

ℹ️ 40 benchmarks have no flame graph

The flamegraph could not be generated because we failed to resolve the symbols in the profiling trace. This happens when we fail to harvest information about language frames.

⚡ 1 improved benchmark
❌ 2 regressed benchmarks
✅ 2405 untouched benchmarks
⏩ 12 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ WallTime starts_with_avx2[64, VarBin] 53.4 µs 60.1 µs -11.17%
❌ Simulation take[routing/grouped_chunks/primitive/nonnull/chunks=32/indices=1000] 385 µs 428.4 µs -10.13%
⚡ WallTime bitpack_blocked_compress_avx2 7.6 µs 6.8 µs +11.74%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/sqllogictests (d39b657) with develop (2ebe999)

Open in CodSpeed

Footnotes

  1. 12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@joseph-isaacs
joseph-isaacs merged commit 5e365e6 into develop Oct 20, 2026
119 of 121 checks passed
@joseph-isaacs
joseph-isaacs deleted the rk/sqllogictests branch October 20, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants