Skip to content

feat(array): add Duration extension dtype - #10467

Closed
mhk197 wants to merge 6 commits into
developfrom
mk/duration-dtype
Closed

mhk197 wants to merge 6 commits into
developfrom
mk/duration-dtype

Conversation

@mhk197

@mhk197 mhk197 commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds vortex.duration, a builtin extension dtype for signed lengths of time. Design follows the existing temporal extension types. It maps directly to Arrow's Duration temporal type, so storage is a primitive i64 array and the Days TimeUnit is rejected.

Implements dtype, array and scalar import/export for Arrow. DuckDB rejects conversion because it has no duration type.

@codspeed

codspeed Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 14.56%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ 1 benchmark measured no execution time

Nothing ran under measurement, usually because the compiler removed the code under test. This result is not comparable, so it counts as unchanged.

Preventing compiler optimizations

⚠️ 13 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 2217 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation decode_primitives[i64, (1000, 32)] 25.1 µs 38.3 µs -34.54%
⚡ WallTime words_gather_dispatch_neon[65536] 2.3 µs 2 µs +11.53%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing mk/duration-dtype (7261620) with develop (5455409)1

Open in CodSpeed

Footnotes

  1. No successful run was found on develop (1d1161f) during the generation of this report, so 5455409 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@mhk197 mhk197 changed the title feat(array): add Duration extension dtype feat(array): add Duration extension dtype Oct 13, 2026
@mhk197 mhk197 added changelog/break A breaking API change changelog/feature A new feature and removed changelog/feature A new feature changelog/break A breaking API change labels Oct 13, 2026
@mhk197
mhk197 marked this pull request as ready for review October 13, 2026 21:14
@mhk197
mhk197 added this pull request to stack #10469 October 13, 2026 21:33
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

This PR has been marked as stale because it has been open for 14 days with no activity. Please comment or remove the stale label if you wish to keep it active, otherwise it will be closed in 7 days

@github-actions github-actions Bot added the stale This PR is stale and will be auto-closed soon label Nov 3, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions Bot closed this Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change stale This PR is stale and will be auto-closed soon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant