Skip to content

Try to find places to deduplicate code in vtable implementations #8806

Closed

Description

@connortsui20

I feel like this would be a good helper function for all of our arrays to make use of. I bet there is a lot of duplication in our vtable impls in general.

Originally posted by @connortsui20 in #8803

Activity

  1. connortsui20 commented on Jul 16, 2026

    @connortsui20
    MemberAuthor
    /// The validity expression for a binary geo kernel: the result is null iff either operand is
    /// null. Returning this lets the planner derive the output's null mask symbolically (mask
    /// pushdown) instead of executing the whole kernel.
    pub(crate) fn binary_result_validity(expression: &Expression) -> VortexResult<Option<Expression>> {
        Ok(Some(and(
            expression.child(0).validity()?,
            expression.child(1).validity()?,
        )))
    }
  2. connortsui20 commented on Jul 21, 2026

    @connortsui20
    MemberAuthor

    @HarukiMoriarty I think one of your PRs closed this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions