You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
List layout writer can fail to serialize sliced ListView chunks #11370
Writing sliced ListViewArray chunks through ListLayoutStrategy can fail with:
Array vortex.slice is not registered for serialization
The writer supports ListView input, but canonicalize_to_list_parts passes the result of list_from_list_view directly to its child writers. Rebuilding can leave a lazy elements slice that a flat child writer cannot serialize. The ListArray branch already calls reset_offsets(false, ...), which also optimizes the elements slice; the ListView branch skips that normalization.
Expected: supported ListView input round-trips through the list layout with its values and nulls preserved.
Steps to reproduce
Restore the ListView path in vortex-layout/src/layouts/list/reader.rs::tests::sliced_list_chunks_round_trip: convert create_ten_element_list_array(true) to ListViewArray, split it at rows [1, 3], and round-trip through chunked_list_strategy(). This fixture includes empty and null lists. Also cover non-nullable input.
The QC fork's layouts::list::reader::tests::sliced_list_chunks_round_trip::case_4_list_view_chunks failed with the error above in this CI job.
Environment
Observed in the QC fork's Rust CI. Upstream develop at 2e1b05b84e7b7a2df5171b1c6c18bfbc93d0c3d7 still has the unnormalized ListView branch; the restored regression has not yet been run against that upstream revision.
Additional context
Related PR: #11082 fixed sliced ListArray offsets. Its ListView test path was removed during review because that change only affected ListArray input. This issue covers the separate serialization failure exposed by that test in the QC fork.
The QC fix applies the existing reset_offsets(false, ...) normalization to both input paths before extracting their data parts.
Activity
fix(layout): normalize rebuilt ListView children before writing (#11371)