Repository navigation
Commit f1465af
Consolidate benchmark SQL queries into
## Rationale for this change
This PR reorganizes benchmark SQL queries by consolidating them into a
centralized `vortex-bench/sql/` directory structure. Previously, queries
were either hardcoded as string arrays in Rust source files or scattered
across different locations. This change improves maintainability by:
1. **Centralizing query definitions**: All SQL queries are now in
dedicated `.sql` files, making them easier to review, edit, and version
control
2. **Improving query discoverability**: Queries are now organized by
benchmark name in a consistent directory structure
3. **Enabling better documentation**: SQL files can include comments
explaining each query's purpose
4. **Reducing code duplication**: Eliminates the need to maintain query
strings in both Rust code and documentation
## What changes are included in this PR?
### New SQL files created:
- `vortex-bench/sql/fineweb.sql` - 9 string-focused queries (Q0-Q8) for
the FineWeb dataset
- `vortex-bench/sql/gharchive.sql` - 5 queries (Q0-Q4) for GitHub
Archive nested event data
### SQL files reorganized:
- Moved existing query files to `vortex-bench/sql/` subdirectories:
- `appian/q{1..8}.sql` → `sql/appian/q{1..8}.sql`
- `tpch/q*.sql` → `sql/tpch/q*.sql`
- `tpcds/{01..99}.sql` → `sql/tpcds/{01..99}.sql`
- `clickbench_queries.sql` → `sql/clickbench_queries.sql`
- `polarsignals.sql` → `sql/polarsignals.sql`
- `spatialbench.sql` → `sql/spatialbench.sql`
- `statpopgen.sql` → `sql/statpopgen.sql`
### Rust source changes:
- **`vortex-bench/src/fineweb/mod.rs`**: Replaced hardcoded `QUERIES`
array with file-based loading from `sql/fineweb.sql`
- **`vortex-bench/src/realnest/gharchive.rs`**: Replaced hardcoded
`QUERIES` array with file-based loading from `sql/gharchive.sql`
- **`vortex-bench/src/appian/mod.rs`**: Updated documentation to reflect
new `sql/appian/` path
- **`vortex-bench/src/clickbench/benchmark.rs`**: Updated default query
file path to `sql/clickbench_queries.sql`
- **`vortex-bench/src/tpch/mod.rs`**,
**`vortex-bench/src/tpcds/mod.rs`**: Updated to use new `sql/` directory
structure
- **Other benchmarks** (`polarsignals`, `spatialbench`, `statpopgen`):
Updated query file paths to use new `sql/` directory
All query loading now uses a consistent pattern: read the SQL file,
split on semicolons, trim whitespace, filter empty statements, and
enumerate for query numbering.
## What APIs are changed? Are there any user-facing changes?
No public APIs are changed. This is an internal reorganization of
benchmark infrastructure. The benchmark behavior remains
identical—queries are loaded and executed in the same order, just from
external files instead of hardcoded strings.
Users running benchmarks will not notice any difference in functionality
or output.
https://claude.ai/code/session_015ANEJi5xgm5tpb16ezGGzd
Signed-off-by: Claude <[email protected]>
Co-authored-by: Claude <[email protected]>vortex-bench/sqldirectory (#8684)1 parent 3e32163 commit f1465af
144 files changed
Lines changed: 92 additions & 33 deletions
File tree
- vortex-bench
- sql
- appian
- tpcds
- tpch
- src
- appian
- clickbench
- fineweb
- polarsignals
- realnest
- spatialbench
- statpopgen
- tpcds
- tpch
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
0 commit comments