Repository navigation
Commit ec0fd92
authored
feat(cuda): Execute Widen arrays on CUDA (#11303)
## Summary
- Tracking Issue: #10701
Progress towards #11284 (part 1).
CUDA has no kernel for `vortex.widen`, and the CPU fallback only runs
when every buffer is on the host, so executing a device-resident `Widen`
fails with "CPU fallback with device-resident buffers is not supported".
After CD5, every DecimalByteParts array with a narrow MSP reads from a
file with an integer `Widen` as its MSP, so CD5 can't merge until GPU
reads can execute it.
## Changes
`Widen` is not fused into the dynamic dispatch path. Dynamic dispatch
zero-extends signed narrow BitPacked and FoR children, so fusing a
signed `Widen` there needs care to sign-extend instead. The `TODO` in
`plan_builder.rs` tracks that. Until then, `WidenExecutor` executes the
child on the device and widens it in a separate kernel.
Decimal storage that is wider than the `Widen`'s logical type is an
error instead of a narrowing copy on the device. Narrowing needs either
an overflow check or trust in the stored precision, and that choice is
the open question in part 2 of #11284.
The decimal path reuses the kernels in `decimal_cast.cu`, and the Arrow
export now shares `widen_decimal_values` with it, so there is one copy
of the widening code. The tests compare every integer and decimal
widening pair against the CPU `Widen` (with nulls, negative values, a
FoR child, and the kernel's block boundaries). They only run in the GPU
CI.
Signed-off-by: Alexander Droste <[email protected]>1 parent ced8ec9 commit ec0fd92
10 files changed
Lines changed: 608 additions & 140 deletions
File tree
- vortex-cuda
- kernels/src
- src
- arrow
- dynamic_dispatch
- kernel
- encodings
- widen
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
14 | 14 | | |
15 | | - | |
16 | | - | |
17 | | - | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
18 | 18 | | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
46 | 22 | | |
47 | 23 | | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
54 | 38 | | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
63 | 42 | | |
64 | 43 | | |
65 | 44 | | |
66 | | - | |
| 45 | + | |
67 | 46 | | |
68 | 47 | | |
69 | 48 | | |
| |||
76 | 55 | | |
77 | 56 | | |
78 | 57 | | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
99 | 63 | | |
100 | 64 | | |
101 | 65 | | |
102 | | - | |
103 | | - | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
48 | 47 | | |
49 | 48 | | |
50 | 49 | | |
51 | 50 | | |
52 | 51 | | |
53 | | - | |
54 | 52 | | |
55 | 53 | | |
56 | | - | |
57 | 54 | | |
58 | 55 | | |
59 | 56 | | |
| |||
62 | 59 | | |
63 | 60 | | |
64 | 61 | | |
65 | | - | |
66 | 62 | | |
67 | 63 | | |
68 | 64 | | |
| |||
92 | 88 | | |
93 | 89 | | |
94 | 90 | | |
| 91 | + | |
95 | 92 | | |
96 | 93 | | |
97 | 94 | | |
| |||
475 | 472 | | |
476 | 473 | | |
477 | 474 | | |
478 | | - | |
479 | 475 | | |
480 | | - | |
| 476 | + | |
481 | 477 | | |
482 | 478 | | |
483 | | - | |
484 | | - | |
485 | | - | |
486 | | - | |
487 | | - | |
488 | | - | |
489 | | - | |
490 | | - | |
491 | | - | |
492 | | - | |
493 | | - | |
494 | | - | |
495 | | - | |
496 | | - | |
497 | | - | |
498 | | - | |
499 | | - | |
500 | | - | |
501 | | - | |
502 | | - | |
503 | | - | |
504 | | - | |
505 | | - | |
506 | | - | |
507 | | - | |
508 | | - | |
509 | | - | |
510 | | - | |
511 | | - | |
512 | | - | |
513 | | - | |
514 | | - | |
515 | | - | |
516 | | - | |
517 | | - | |
518 | | - | |
519 | | - | |
520 | | - | |
521 | | - | |
522 | | - | |
523 | | - | |
524 | | - | |
525 | | - | |
526 | | - | |
527 | | - | |
528 | | - | |
529 | | - | |
530 | | - | |
531 | | - | |
532 | | - | |
533 | | - | |
534 | | - | |
535 | | - | |
536 | | - | |
537 | | - | |
538 | | - | |
539 | | - | |
540 | | - | |
541 | | - | |
542 | | - | |
543 | | - | |
544 | | - | |
| 479 | + | |
545 | 480 | | |
546 | 481 | | |
547 | 482 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
133 | 133 | | |
134 | 134 | | |
135 | 135 | | |
| 136 | + | |
| 137 | + | |
136 | 138 | | |
137 | 139 | | |
138 | 140 | | |
| |||
0 commit comments