Skip to content

Commit e202a68

Browse files
authored
test: add a should_panic test (for now) for #4503 (#4504)
I'm hunting a different issue in pco, but this is the first tiny & failing test case I found. Signed-off-by: Daniel King <[email protected]>
1 parent 4591cf5 commit e202a68

2 files changed

Lines changed: 15 additions & 3 deletions

File tree

‎encodings/pco/src/array.rs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -251,20 +251,20 @@ impl PcoArray {
251251
#[allow(clippy::unwrap_in_result, clippy::unwrap_used)]
252252
fn decompress_values_typed<T: Number>(&self) -> ByteBuffer {
253253
// To start, we figure out what range of values we need to decompress.
254-
let slice_n_rows = self.slice_stop - self.slice_start;
255254
let slice_value_indices = self
256255
.unsliced_validity
257256
.to_mask(self.unsliced_n_rows)
258257
.valid_counts_for_indices(&[self.slice_start, self.slice_stop]);
259258
let slice_value_start = slice_value_indices[0];
260259
let slice_value_stop = slice_value_indices[1];
260+
let slice_n_values = slice_value_stop - slice_value_start;
261261

262262
// Then we decompress those pages into a buffer. Note that these values
263263
// may exceed the bounds of the slice, so we need to slice later.
264264
let (fd, _) = FileDecompressor::new(self.metadata.header.as_slice())
265265
.map_err(vortex_err_from_pco)
266266
.vortex_unwrap();
267-
let mut decompressed_values = BufferMut::<T>::with_capacity(slice_n_rows);
267+
let mut decompressed_values = BufferMut::<T>::with_capacity(slice_n_values);
268268
let mut page_idx = 0;
269269
let mut page_value_start = 0;
270270
let mut n_skipped_values = 0;
@@ -317,7 +317,7 @@ impl PcoArray {
317317
let value_offset = slice_value_start - n_skipped_values;
318318
decompressed_values
319319
.freeze()
320-
.slice(value_offset..value_offset + slice_n_rows)
320+
.slice(value_offset..value_offset + slice_n_values)
321321
.into_byte_buffer()
322322
}
323323

‎encodings/pco/src/test.rs‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ use vortex_array::validity::Validity;
88
use vortex_array::vtable::ValidityHelper;
99
use vortex_buffer::Buffer;
1010
use vortex_mask::Mask;
11+
use vortex_scalar::Scalar;
1112

1213
use crate::PcoArray;
1314

@@ -42,6 +43,17 @@ fn test_compress_decompress() {
4243
assert_eq!(primitive.as_slice::<i32>(), &Vec::<i32>::new());
4344
}
4445

46+
#[test]
47+
fn test_compress_decompress_big() {
48+
let array = PrimitiveArray::from_option_iter([None, Some(1)]);
49+
let compressed = PcoArray::from_primitive(&array, 3, 0).unwrap();
50+
assert_eq!(compressed.scalar_at(0), Scalar::null_typed::<i32>());
51+
assert_eq!(compressed.scalar_at(1), Scalar::from(Some(1)));
52+
let decompressed = compressed.decompress();
53+
assert_eq!(decompressed.scalar_at(0), Scalar::null_typed::<i32>());
54+
assert_eq!(decompressed.scalar_at(1), Scalar::from(Some(1)));
55+
}
56+
4557
#[test]
4658
fn test_empty() {
4759
let data: Vec<i32> = vec![];

0 commit comments

Comments
 (0)