You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit d040485
Browse filesBrowse the repository at this point in the historyBrowse files
Check scalar fn inputs in place before execute_step requests them
CodSpeed flagged the scalar_fn probe benchmarks on Binary (bool AND
about 14% slower). A probe executes the function over constant
single-row inputs, so the per-call cost of execute_step dominates:
- Binary's AND/OR check called constant_boolean, which with two constant
operands computed the whole result only for execute to compute it
again. It now only checks whether an operand is a constant, and skips
the check entirely when both operands are already columnar.
- Every check cloned its input through ExecutionArgs::get. A new
provided method, ExecutionArgs::input_matches, tests an input in
place; VecExecutionArgs and the row-function args override it to
avoid the clone, and require_input!, Binary, Like and FillNull use it.
Locally, interleaved runs of the probe benchmarks against develop go
from up to +30% to within +4%, except valid_repeated on bool at about
+14% (under 15 ns per call).
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01UeniBEMPLG2FLT3ZFA1auB
Signed-off-by: Joe Isaacs <[email protected]>
0 commit comments