Skip to content

Commit c97dc82

Browse files
robert3005claude
andcommitted
Explain non-nullable IN list scalars
Signed-off-by: Robert Kruszewski <[email protected]> Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 72ea74e commit c97dc82

2 files changed

Lines changed: 3 additions & 0 deletions

File tree

‎vortex-duckdb/src/convert/expr.rs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -741,6 +741,7 @@ fn try_from_compare_in(
741741
else {
742742
return Ok(None);
743743
};
744+
// The IN list itself is never null. Null values are elements, and in_list handles them.
744745
let list = Scalar::list(
745746
Arc::new(list_elements[0].dtype().clone()),
746747
list_elements,

‎vortex-duckdb/src/convert/table_filter.rs‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,8 @@ pub fn try_from_table_filter(
8787
"IN filter must have at least one value"
8888
);
8989
let dtype = scalars[0].dtype().clone();
90+
// The IN list itself is never null. Null values are elements, and in_list handles
91+
// them.
9092
let list_scalar = Scalar::list(Arc::new(dtype), scalars, Nullability::NonNullable);
9193
in_list(col.clone(), lit(list_scalar))
9294
}

0 commit comments

Comments
 (0)