Skip to content

Commit c13ee65

Browse files
committed
docs: trim decimal benchmark comments
Signed-off-by: Connor Tsui <[email protected]>
1 parent 99dadb0 commit c13ee65

1 file changed

Lines changed: 0 additions & 8 deletions

File tree

  • encodings/decimal-byte-parts/benches/common

‎encodings/decimal-byte-parts/benches/common/mod.rs‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,6 @@ const WIDTHS: [(DecimalType, usize); 2] = [
2020
];
2121

2222
/// Working set per kernel iteration.
23-
///
24-
/// The kernel benchmarks run on the walltime legs, where a case that takes under a microsecond
25-
/// reports mostly per-iteration jitter: at 1,024 rows the `i128` kernels took 0.4 to 1.2 µs and
26-
/// moved by 10 to 19% on pull requests that changed no decimal code. Budgeting by bytes puts
27-
/// every case in the microsecond range, and the largest one still fits the 1 MiB L2 cache of the
28-
/// Graviton leg, so these stay measurements of kernel code rather than of memory bandwidth.
2923
const WORKING_SET_BYTES: [usize; 2] = [256 * 1024, 1024 * 1024];
3024

3125
pub(super) fn cases() -> Vec<(DecimalType, usize)> {
@@ -66,8 +60,6 @@ pub(super) mod arrays {
6660
use super::i128_values;
6761
use super::i256_values;
6862

69-
/// These benchmarks never run in CI, so they keep the small row counts that make a local
70-
/// `cargo bench` quick, rather than the kernel benchmarks' walltime-safe sizes.
7163
pub(crate) fn cases() -> Vec<(DecimalType, usize)> {
7264
[DecimalType::I64, DecimalType::I128, DecimalType::I256]
7365
.into_iter()

0 commit comments

Comments
 (0)