You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit be70183
Browse filesBrowse the repository at this point in the historyBrowse files
Collapse VortexError into a single message-carrying error
VortexError had an enum variant per failure mode and per foreign error
type (Arrow, flatbuffers, prost, io, object_store, jiff, ...). Callers
rarely branched on the variant, and keeping one per dependency made the
type large and the set of variants grow with every new dependency.
A VortexError is now a message, an optional source and a backtrace. A
foreign error is kept as the source and recovered by downcasting, and
context is added in place with with_context. The payload sits behind a
single Arc, so VortexError and VortexResult<()> are one pointer wide,
which keeps most results in registers on the success path.
The error macros take a plain format string, plus the Context: and
External: forms. Call sites that used the variant-specific forms now pass
a message, and errors that were formatted into new errors now add
context instead, so their source and backtrace survive. Tests that
matched on a variant now assert on the guard's message.
Python raises RuntimeError for every Vortex error, as before. The C API
reports VX_ERROR_CODE_OTHER for Vortex errors and VX_ERROR_CODE_PANIC for
panics, at their existing values; the other codes are retired, and the
C++ ErrorCode mirrors the C enum.
Signed-off-by: Robert Kruszewski <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01S7EtMqoZ91rrCCh9vS2yTm
0 commit comments