You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit b161445
Browse filesBrowse the repository at this point in the historyBrowse files
FoRScheme: declare and refine its bit-packed child (#10757)
## Summary
`FoRScheme` bit-packed its child by calling `BITPACKING_V1` directly,
without declaring the bit-packing IDs. The builder kept FoR when
`fastlanes.bitpacked` (or `vortex.patched`) was disallowed, so the write
failed, and the child never used `fastlanes.bitpacked.v2`. FoR now holds
the `BitPackingScheme` it uses, declares that scheme's IDs, and refines
it alongside the references.
Closes#10751.
## Changes
- `FoRScheme` gets a `bitpacking` field, and `produced_encodings`
appends its IDs.
- `refine` picks the references and the child's bit widths independently
(four statics).
- The child is compressed with FoR's context rather than a leaf one, so
v2 block offsets can cascade.
Core-edition and CUDA output is unchanged. Sessions that allow
`fastlanes.bitpacked.v2` now get blocked children under FoR (fused
decode from #10251).
## Testing
- `builder.rs`: FoR is dropped without `fastlanes.bitpacked` and kept
with it.
- `for_.rs`, `tests/for_config.rs`: FoR refines to a blocked child when
`fastlanes.bitpacked.v2` is allowed, and the compressed output
serializes it.
## Follow-up
Excluding `BitPackingScheme` by scheme ID still doesn't stop FoR from
bit-packing (documented on `FoRScheme`).
---------
Signed-off-by: Matt Katz <[email protected]>
0 commit comments