Skip to content

Commit 9fdc456

Browse files
committed
bench: delete the search_sorted benchmark
It searched a plain Vec<i32>, which is not a shape Vortex uses: every production caller goes through SearchSortedPrimitiveArray over an array (patches.rs:595, encodings/runend/src/ops.rs, chunked/array.rs). Those paths are already covered on realistic data by patches_lookup.rs, which benchmarks patches.search_index across several query distributions, and by run_end_take / run_end_filter. What was left that is unique to it was a comparison against std binary_search on a Vec, which guards nothing -- std is not a drop-in for the array case -- and until this branch it could not even tell the two implementations apart (203 vs 206 instructions per iteration, ~71% of it harness). Removes the binary_search_std and binary_search_vortex ids, which will need archiving on the dashboard along with the rest of the #8807 backlog. Signed-off-by: Claude <[email protected]> Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_015ypCZPxvLuJK9FgWKF8U4P
1 parent d8226ff commit 9fdc456

2 files changed

Lines changed: 0 additions & 67 deletions

File tree

‎vortex-array/Cargo.toml‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -113,10 +113,6 @@ harness = false
113113
name = "cast_decimal"
114114
harness = false
115115

116-
[[bench]]
117-
name = "search_sorted"
118-
harness = false
119-
120116
[[bench]]
121117
name = "scalar_subtract"
122118
harness = false

‎vortex-array/benches/search_sorted.rs‎

Lines changed: 0 additions & 63 deletions
This file was deleted.

0 commit comments

Comments
 (0)