You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 9876921
Browse filesBrowse the repository at this point in the historyBrowse files
Replace ScalarFnVTable::is_fallible with is_infallible (#9511)
## Rationale for this change
Flips the polarity of the fallibility hook so the conservative answer is
the default. A scalar function now opts in to being infallible by
overriding `is_infallible` to return `true`, instead of opting out of
the fallible default.
## What changes are included in this PR?
Renames `ScalarFnVTable::is_fallible` to `is_infallible` along with the
`DynScalarFn` and `ScalarFnSignature` mirrors, and inverts every
implementation and call site (dictionary push-down, the dict layout
pushdown split, and `ExpressionTakeRule`). Also renames the
`label_is_fallible` expression analysis to `label_infallible` so it
matches `label_strict`, and inverts its tests in place.
## What APIs are changed? Are there any user-facing changes?
`ScalarFnSignature::is_fallible` becomes `is_infallible` and
`label_is_fallible` becomes `label_infallible`, both with flipped return
values. Out-of-tree `ScalarFnVTable` implementations must rename their
`is_fallible` override and invert the result, and an override that
returned `true` can now rely on the default.
---
_Generated by [Claude
Code](https://claude.ai/code/session_011DaVCc8ZmJ13JtPGQYMM3o)_
---------
Signed-off-by: Claude <[email protected]>
Co-authored-by: Claude <[email protected]>
0 commit comments