Skip to content

Commit 9031788

Browse files
authored
Fill in missing functionality for maps in fuzzer (#9208)
## Rationale for this change Over-eager LLMs did this back and forth on fuzzing maps, this is the missing piece. --------- Signed-off-by: Adam Gutglick <[email protected]>
1 parent c3639a2 commit 9031788

1 file changed

Lines changed: 22 additions & 1 deletion

File tree

‎fuzz/src/array/scalar_at.rs‎

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,12 @@ use std::sync::Arc;
66
use vortex_array::Canonical;
77
use vortex_array::ExecutionCtx;
88
use vortex_array::IntoArray;
9+
use vortex_array::arrays::StructArray;
910
use vortex_array::arrays::bool::BoolArrayExt;
1011
use vortex_array::arrays::extension::ExtensionArrayExt;
1112
use vortex_array::arrays::fixed_size_list::FixedSizeListArrayExt;
1213
use vortex_array::arrays::listview::ListViewArrayExt;
14+
use vortex_array::arrays::map::MapArrayExt;
1315
use vortex_array::arrays::struct_::StructArrayExt;
1416
use vortex_array::arrays::varbin::varbin_scalar;
1517
use vortex_array::dtype::DType;
@@ -107,7 +109,26 @@ pub fn scalar_at_canonical_array(
107109
Canonical::Union(_) => {
108110
todo!("TODO(connor)[Union]: support Union arrays in the scalar_at fuzzer")
109111
}
110-
Canonical::Map(_) => unreachable!("Map arrays are not fuzzed"),
112+
Canonical::Map(array) => {
113+
let entries = array.entries_at(index)?.execute::<StructArray>(ctx)?;
114+
let keys = entries
115+
.unmasked_field(0)
116+
.clone()
117+
.execute::<Canonical>(ctx)?;
118+
let values = entries
119+
.unmasked_field(1)
120+
.clone()
121+
.execute::<Canonical>(ctx)?;
122+
let pairs = (0..entries.len())
123+
.map(|entry_index| {
124+
Ok((
125+
scalar_at_canonical_array(keys.clone(), entry_index, ctx)?,
126+
scalar_at_canonical_array(values.clone(), entry_index, ctx)?,
127+
))
128+
})
129+
.collect::<VortexResult<Vec<_>>>()?;
130+
Scalar::try_map(array.dtype().clone(), pairs)?
131+
}
111132
Canonical::Variant(_) => unreachable!("Variant arrays are not fuzzed"),
112133
})
113134
}

0 commit comments

Comments
 (0)