Repository navigation
Commit 8d58672
committed
Give the results of the storage pushdown the extension dtype
`ExtensionStoragePushdown` returned the results of its aggregate over
storage values unchanged. So `vortex.min_max[vortex.timestamp]` gave raw
`i64` values without the time unit or zone, while plain `min_max` gives
timestamps.
The new `StorageResultMapping` trait names the value fields of a partial
and a result, which hold input values, and `MinMax` and `IsSorted`
implement it. The pushdown requires the trait, so an aggregate without a
mapping does not compile. Partial states stay in storage form in memory.
`to_scalar` and `finalize_scalar` give their output the extension dtype,
`partial_from_scalar` removes it, and `finalize` receives states that
already have it.
The tests now compare the pushdown with plain `min_max` over flat,
chunked, constant, dictionary-encoded, and grouped input, and check that
an `is_sorted` partial with a null first value survives its round trip
through a scalar. The test that registered the pushdown by hand is gone,
because the default session test already checks the registration.
Signed-off-by: Connor Tsui <[email protected]>1 parent 8fea5fd commit 8d58672
4 files changed
Lines changed: 241 additions & 107 deletions
File tree
- encodings/uuid/src
- vortex-array/src/aggregate_fn
- fns
- is_sorted
- min_max
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
158 | 158 | | |
159 | 159 | | |
160 | 160 | | |
161 | | - | |
162 | | - | |
163 | | - | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
168 | 171 | | |
169 | 172 | | |
170 | 173 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| 35 | + | |
35 | 36 | | |
36 | 37 | | |
37 | 38 | | |
| |||
582 | 583 | | |
583 | 584 | | |
584 | 585 | | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
585 | 592 | | |
586 | 593 | | |
587 | 594 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
37 | 38 | | |
38 | 39 | | |
39 | 40 | | |
| |||
538 | 539 | | |
539 | 540 | | |
540 | 541 | | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
541 | 548 | | |
542 | 549 | | |
543 | 550 | | |
| |||
0 commit comments