Skip to content

Commit 69fae0c

Browse files
committed
Document dense retry correctness
Signed-off-by: Connor Tsui <[email protected]>
1 parent 663144e commit 69fae0c

2 files changed

Lines changed: 9 additions & 5 deletions

File tree

‎vortex-array/src/scalar_fn/unstable/row/batch/execute/dense.rs‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,11 @@ impl RowFnExecutionArgs {
2626
self.finalize_dense_output(values, ctx)
2727
}
2828

29-
/// Run every stored payload, resolving a deferred error against input validity.
29+
/// Run all stored payloads, retrying valid rows only when reduced failure evidence is rejected.
30+
///
31+
/// Validity stays lazy on success because masking makes null-row values unobservable. Rejected
32+
/// evidence loses which row failed, so validity decides whether to return, suppress, or
33+
/// recompute the error.
3034
pub(super) fn execute_dense_with_retry(
3135
&self,
3236
execute_dense_attempt: impl FnOnce(

‎vortex-array/src/scalar_fn/unstable/row/visitor/row_visitor.rs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -199,10 +199,10 @@ pub trait RowVisitor<Options>: private::Sealed + Sized {
199199
/// The executor OR-reduces [`FailureEvidence`] across rows and passes the result to
200200
/// `finish_failure`.
201201
///
202-
/// If `finish_failure` rejects the evidence from dense execution, batch execution materializes
203-
/// input validity. It returns the error for an all-valid batch, returns an all-null output for
204-
/// an all-null batch, and runs `apply` again over valid rows for a partially valid batch. A
205-
/// prepared retry also runs `prepare` again.
202+
/// If `finish_failure` rejects dense evidence, reduction has lost which row failed. Batch
203+
/// execution therefore resolves input validity: it preserves the error for all-valid input,
204+
/// suppresses it for all-null input, and retries `apply` over valid rows for partially valid
205+
/// input. A prepared retry also runs `prepare` again.
206206
///
207207
/// [`RowFn::INFALLIBLE`](crate::scalar_fn::unstable::row::RowFn::INFALLIBLE) **must** be
208208
/// `false`. `Out` must not require drop glue. `Fail` must be no wider than `Out`, or failure

0 commit comments

Comments
 (0)